deploy CRC with leader election #649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot
added
area/control-plane
|
/cc @MartinWeindel |
gardener-robot-ci-2
added
the
reviewed/ok-to-test
gardener-robot
added
the
reviewed/do-not-merge
gardener-robot-ci-2
added
needs/ok-to-test
timuthy
reviewed
Nov 21, 2022
| @@ -11,4 +11,4 @@ rules: | |||
| verbs: | |||
| - get | |||
| - list | |||
| - watch | |||
| - watch | |||
There was a problem hiding this comment.
Can you revert this change? I assume it happened by accident.
| name: extensions.gardener.cloud:provider-aws:aws-custom-route-controller | ||
| namespace: kube-system | ||
| rules: | ||
| - apiGroups: |
There was a problem hiding this comment.
Suggested change
| - apiGroups: | |
| - apiGroups: |
Nit: Use same indentation as in other files
| resources: | ||
| - leases | ||
| verbs: | ||
| - create |
Comment on lines
7
to
9
| - kind: ServiceAccount | ||
| name: aws-custom-route-controller | ||
| namespace: kube-system |
There was a problem hiding this comment.
Suggested change
| - kind: ServiceAccount | |
| name: aws-custom-route-controller | |
| namespace: kube-system | |
| - kind: ServiceAccount | |
| name: aws-custom-route-controller | |
| namespace: kube-system |
gardener-robot-ci-3
added
the
reviewed/ok-to-test
gardener-robot-ci-1
removed
the
reviewed/ok-to-test
gardener-robot
added
reviewed/lgtm
|
/unhold CRC release has already been merged |
gardener-robot
removed
the
reviewed/do-not-merge
gardener-robot
added
the
status/closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area control-plane
/kind enhancement
/platform aws
What this PR does / why we need it:
Deploy CRC with leader election. Depends on CRC releasing after gardener/aws-custom-route-controller#3
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: