Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GEP-20] Change StorageClass to WaitForFirstConsumer #565

Merged
merged 1 commit into from
Aug 25, 2022

Conversation

timuthy
Copy link
Member

@timuthy timuthy commented Aug 25, 2022

How to categorize this PR?

/area control-plane
/area high-availability
/kind enhancement
/platform azure

What this PR does / why we need it:
This PR changes the gardener.cloud-fast storage class do define volumeBindingMode: WaitForFirstConsumer. Scheduling HA shoot control-planes requires the volume creation to respect podAffinity and podAntiaffinities, so that stateful pods can either be schedules across zones or in a single zone only (zone pinning). Without this change, volumes are created in random zones which makes affected pods being stuck in Pending (ref).

Which issue(s) this PR fixes:
Fixes partially gardener/gardener#6529

Special notes for your reviewer:
/cc @kon-angelo

Release note:

The `gardener.cloud-fast` storage class is now deployed with `volumeBindingMode: WaitForFirstConsumer`. This change is required if stateful pods with volumes have a topology related `podAffinity` or `podAntiAffinity` defined, e.g. when Gardener creates control-planes for HA shoot clusters.

@timuthy timuthy requested review from a team as code owners August 25, 2022 11:09
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Aug 25, 2022
Copy link
Contributor

@kon-angelo kon-angelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kon-angelo kon-angelo merged commit c86f81b into gardener:master Aug 25, 2022
@timuthy timuthy deleted the enhancement.storage-class branch August 25, 2022 12:42
@gardener-robot gardener-robot added area/control-plane Control plane related area/high-availability High availability related kind/enhancement Enhancement, improvement, extension platform/azure Microsoft Azure platform/infrastructure size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) reviewed/lgtm Has approval for merging status/closed Issue is closed (either delivered or triaged) labels Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/control-plane Control plane related area/high-availability High availability related kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) platform/azure Microsoft Azure platform/infrastructure reviewed/lgtm Has approval for merging size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants