Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-v1.35] Automated cherry pick of #671: allow rg deletion with other resources #676

Merged
merged 1 commit into from
Apr 24, 2023
Merged

[release-v1.35] Automated cherry pick of #671: allow rg deletion with other resources #676

merged 1 commit into from
Apr 24, 2023

Conversation

kon-angelo
Copy link
Contributor

/area control-plane
/kind regression

Cherry pick of #671 on release-v1.35.

#671: allow rg deletion with other resources

Release Notes:

Restore terraform behavior to delete the azure resource group even if it contains other resources.

@kon-angelo kon-angelo requested review from a team as code owners April 24, 2023 10:57
@gardener-robot gardener-robot added area/control-plane Control plane related kind/regression Bug that hit us already in the past and that is reappearing/requires a proper solution needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Apr 24, 2023
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Apr 24, 2023
MartinWeindel
MartinWeindel approved these changes Apr 24, 2023
View reviewed changes
Copy link
Member

@MartinWeindel MartinWeindel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Apr 24, 2023
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 24, 2023
@kon-angelo kon-angelo merged commit b04c81f into gardener:release-v1.35 Apr 24, 2023
@kon-angelo kon-angelo deleted the automated-cherry-pick-of-#671-origin-release-v1.35 branch April 24, 2023 11:21
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartinWeindel MartinWeindel MartinWeindel approved these changes

Assignees
No one assigned
Labels
area/control-plane Control plane related kind/regression Bug that hit us already in the past and that is reappearing/requires a proper solution needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kon-angelo @MartinWeindel @gardener-robot-ci-2 @gardener-robot