Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vendor gardener/gardener@1.70.2 and adapt provider-extension for workerless Shoot #685

Merged
merged 7 commits into from
May 17, 2023
Merged

Vendor gardener/gardener@1.70.2 and adapt provider-extension for workerless Shoot #685

merged 7 commits into from
May 17, 2023

Conversation

acumino
Copy link
Member

@acumino acumino commented May 11, 2023 •
edited
Loading

How to categorize this PR?

/area control-plane
/kind enhancement
/platform azure

What this PR does / why we need it:

  • Vendor gardener v1.70.2
  • Skip mutation and validation for shoots if it's workerless.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

The following dependency has been updated:
- github.com/gardener/gardener 1.67.1 -> 1.70.2

@gardener-robot gardener-robot added area/control-plane Control plane related kind/enhancement Enhancement, improvement, extension platform/azure Microsoft Azure platform/infrastructure needs/review Needs review size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) labels May 11, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels May 11, 2023
@acumino acumino force-pushed the vendor/gardener@1.70.2 branch from e27a854 to b268509 Compare May 12, 2023 09:49
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 12, 2023
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 12, 2023
@acumino acumino mentioned this pull request May 12, 2023
Closed
31 tasks
@acumino
Copy link
Member Author

acumino commented May 12, 2023

/test

@testmachinery
Copy link

testmachinery bot commented May 12, 2023 •
edited
Loading

Testrun: e2e-j4tll
Workflow: e2e-j4tll-wf
Phase: Succeeded

+---------------------+---------------------+-----------+----------+
|        NAME         |        STEP         |   PHASE   | DURATION |
+---------------------+---------------------+-----------+----------+
| infrastructure-test | infrastructure-test | Succeeded | 34m51s   |
| bastion-test        | bastion-test        | Succeeded | 10m40s   |
+---------------------+---------------------+-----------+----------+

@acumino acumino marked this pull request as ready for review May 12, 2023 11:03
@acumino acumino requested review from a team as code owners May 12, 2023 11:03
MartinWeindel
MartinWeindel previously approved these changes May 12, 2023
View reviewed changes
Copy link
Member

@MartinWeindel MartinWeindel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels May 12, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 12, 2023
@acumino
Copy link
Member Author

acumino commented May 12, 2023

/hold
for testing changes locally.

@gardener-robot gardener-robot added the reviewed/do-not-merge Has no approval for merging as it may break things, be of poor quality or have (ext.) dependencies label May 12, 2023
@acumino acumino force-pushed the vendor/gardener@1.70.2 branch from b268509 to c2e098d Compare May 16, 2023 15:41
@gardener-robot gardener-robot added needs/review Needs review and removed needs/review Needs review labels May 16, 2023
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 16, 2023
@acumino
Copy link
Member Author

acumino commented May 17, 2023

/unhold
/cc @MartinWeindel

@gardener-robot gardener-robot removed the reviewed/do-not-merge Has no approval for merging as it may break things, be of poor quality or have (ext.) dependencies label May 17, 2023
MartinWeindel
MartinWeindel approved these changes May 17, 2023
View reviewed changes
Copy link
Member

@MartinWeindel MartinWeindel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@acumino
Copy link
Member Author

acumino commented May 17, 2023

/test

@testmachinery
Copy link

testmachinery bot commented May 17, 2023 •
edited
Loading

Testrun: e2e-fkcsq
Workflow: e2e-fkcsq-wf
Phase: Succeeded

+---------------------+---------------------+-----------+----------+
|        NAME         |        STEP         |   PHASE   | DURATION |
+---------------------+---------------------+-----------+----------+
| infrastructure-test | infrastructure-test | Succeeded | 30m36s   |
| bastion-test        | bastion-test        | Succeeded | 11m13s   |
+---------------------+---------------------+-----------+----------+

@acumino acumino changed the title Vendor gardener/gardener@1.70.2 Vendor gardener/gardener@1.70.2 and adapt provider-extension for workerless Shoot May 17, 2023
@acumino acumino changed the title Vendor gardener/gardener@1.70.2 and adapt provider-extension for workerless Shoot Vendor gardener/gardener@1.70.2 and adapt provider-extension for workerless Shoot May 17, 2023
@kon-angelo kon-angelo merged commit cb6d3fc into gardener:master May 17, 2023
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label May 17, 2023
@acumino acumino deleted the vendor/gardener@1.70.2 branch May 17, 2023 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartinWeindel MartinWeindel MartinWeindel approved these changes

Assignees
No one assigned
Labels
area/control-plane Control plane related kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) platform/azure Microsoft Azure platform/infrastructure reviewed/lgtm Has approval for merging size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@acumino @MartinWeindel @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot @kon-angelo