Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable vm boot diagnostics #808

Merged
merged 3 commits into from
Jun 24, 2024
Merged

Enable vm boot diagnostics #808

merged 3 commits into from
Jun 24, 2024

Conversation

hebelsan
Copy link
Contributor

How to categorize this PR?

/area usability
/kind enhancement
/platform azure

What this PR does / why we need it:

  • Add support to enable vm boot diagnostics in the worker providerConfig

Which issue(s) this PR fixes:
Fixes #786

Special notes for your reviewer:

Release note:

Extension-Provider-Azure now supports enabling of vm boot diagnostics in the worker providerConfig.

@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Mar 20, 2024
@hebelsan hebelsan marked this pull request as ready for review March 20, 2024 09:41
@hebelsan hebelsan requested review from a team as code owners March 20, 2024 09:41
@hebelsan hebelsan changed the title Boot diag Enable Boot diagnostics Mar 20, 2024
@hebelsan hebelsan changed the title Enable Boot diagnostics Enable boot diagnostics Mar 20, 2024
@hebelsan hebelsan changed the title Enable boot diagnostics Enable vm boot diagnostics Mar 20, 2024
@gardener-robot gardener-robot added kind/api-change API change with impact on API users needs/second-opinion Needs second review by someone else area/usability Usability related kind/enhancement Enhancement, improvement, extension platform/azure Microsoft Azure platform/infrastructure needs/review Needs review size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) labels Mar 20, 2024
@kon-angelo
Copy link
Contributor

/hold for gardener/machine-controller-manager-provider-azure#136

@kon-angelo kon-angelo added the reviewed/do-not-merge Has no approval for merging as it may break things, be of poor quality or have (ext.) dependencies label Mar 20, 2024
@kon-angelo
Copy link
Contributor

/unhold

@gardener-robot gardener-robot removed the reviewed/do-not-merge Has no approval for merging as it may break things, be of poor quality or have (ext.) dependencies label Jun 20, 2024
@kon-angelo
Copy link
Contributor

/needs rebase

@gardener-robot gardener-robot added the needs/rebase Needs git rebase label Jun 20, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jun 20, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jun 20, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jun 20, 2024
kon-angelo
kon-angelo approved these changes Jun 24, 2024
View reviewed changes
Copy link
Contributor

@kon-angelo kon-angelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/rebase Needs git rebase needs/review Needs review needs/second-opinion Needs second review by someone else labels Jun 24, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jun 24, 2024
@hebelsan hebelsan merged commit 1bd3cfc into gardener:master Jun 24, 2024
14 checks passed
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kon-angelo kon-angelo kon-angelo approved these changes

Assignees
No one assigned
Labels
area/usability Usability related kind/api-change API change with impact on API users kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) platform/azure Microsoft Azure platform/infrastructure reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable Serial Console Support in Worker Node
5 participants
@hebelsan @kon-angelo @gardener-robot-ci-1 @gardener-robot-ci-3 @gardener-robot