Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add operatingsystem label #816

Merged
merged 1 commit into from
Apr 11, 2024
Merged

add operatingsystem label #816

merged 1 commit into from
Apr 11, 2024

Conversation

tedteng
Copy link
Contributor

@tedteng tedteng commented Apr 3, 2024

How to categorize this PR?

/area ops-productivity
/kind enhancement
/platform azure

What this PR does / why we need it:

Which issue(s) this PR fixes:
gardener/machine-controller-manager#880

Special notes for your reviewer:

Release note:

add os information as labels in machine class objects.

@tedteng tedteng requested review from a team as code owners April 3, 2024 05:52
@gardener-robot gardener-robot added the needs/review Needs review label Apr 3, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 3, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Apr 3, 2024
@gardener-robot gardener-robot added area/ops-productivity Operator productivity related (how to improve operations) kind/enhancement Enhancement, improvement, extension platform/azure Microsoft Azure platform/infrastructure size/s Size of pull request is small (see gardener-robot robot/bots/size.py) labels Apr 3, 2024
kon-angelo
kon-angelo approved these changes Apr 4, 2024
View reviewed changes
Copy link
Contributor

@kon-angelo kon-angelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Apr 4, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 4, 2024
@AndreasBurger AndreasBurger merged commit b859d7b into gardener:master Apr 11, 2024
18 checks passed
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kon-angelo kon-angelo kon-angelo approved these changes

Assignees
No one assigned
Labels
area/ops-productivity Operator productivity related (how to improve operations) kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) platform/azure Microsoft Azure platform/infrastructure reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/s Size of pull request is small (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@tedteng @kon-angelo @AndreasBurger @gardener-robot-ci-1 @gardener-robot-ci-3 @gardener-robot