Data disk image reference #891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot
added
kind/api-change
|
@hebelsan You need rebase this pull request with latest master branch. Please check. |
gardener-robot
added
needs/review
gardener-robot-ci-1
added
the
reviewed/ok-to-test
gardener-robot-ci-1
added
needs/ok-to-test
gardener-robot-ci-1
added
the
reviewed/ok-to-test
gardener-robot-ci-3
removed
the
reviewed/ok-to-test
gardener-robot-ci-3
added
the
reviewed/ok-to-test
gardener-robot-ci-2
removed
the
reviewed/ok-to-test
|
/hold until gardener/machine-controller-manager-provider-azure#165 is merged and released |
gardener-robot
added
the
reviewed/do-not-merge
hebelsan
force-pushed
the
disk-image-ref
branch
from
e67ccea
to
ec3a01d
Compare
gardener-robot-ci-3
added
reviewed/ok-to-test
gardener-robot-ci-2
added
the
reviewed/ok-to-test
gardener-robot-ci-1
removed
the
reviewed/ok-to-test
hebelsan
force-pushed
the
disk-image-ref
branch
from
634bfc1
to
6b594f8
Compare
gardener-robot-ci-3
added
the
reviewed/ok-to-test
gardener-robot-ci-1
removed
the
reviewed/ok-to-test
gardener-robot-ci-1
added
reviewed/ok-to-test
gardener-robot-ci-1
added
the
reviewed/ok-to-test
gardener-robot-ci-2
removed
the
reviewed/ok-to-test
gardener-robot-ci-1
added
the
reviewed/ok-to-test
gardener-robot-ci-2
removed
the
reviewed/ok-to-test
kon-angelo
reviewed
Oct 1, 2024
| @@ -19,8 +19,13 @@ type WorkerConfig struct { | |||
| // NodeTemplate contains resource information of the machine which is used by Cluster Autoscaler to generate nodeTemplate during scaling a nodeGroup from zero. | |||
| // +optional | |||
| NodeTemplate *extensionsv1alpha1.NodeTemplate `json:"nodeTemplate,omitempty"` | |||
| // DiagnosticsProfile specifies boot diagnostic options | |||
|
|
|||
| // DiagnosticsProfile specifies boot diagnostic options. | |||
There was a problem hiding this comment.
since you went into the trouble to add the new line, please also add the +optional here
| // +optional | ||
| SkipMarketplaceAgreement *bool `json:"skipMarketplaceAgreement,omitempty"` | ||
| // Image identifies the azure image. | ||
| Image |
There was a problem hiding this comment.
I am not sure if we want to do that or something like:
imageRef Image `json",inline"`
I think this is more clean to be honest and I believe this to be backwards compatible too. WDYT ?
gardener-robot-ci-2
added
the
reviewed/ok-to-test
gardener-robot-ci-1
removed
the
reviewed/ok-to-test
gardener-robot-ci-1
added
reviewed/ok-to-test
gardener-robot
added
reviewed/lgtm
gardener-robot-ci-3
added
the
reviewed/ok-to-test
gardener-robot
added
the
status/closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area usability
/kind enhancement
/platform azure
What this PR does / why we need it:
Adds the ability to attach dataDisks with image references
Which issue(s) this PR fixes:
Fixes #788
Special notes for your reviewer:
Release note: