Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add object selector to the shoot webhook #903

Merged
merged 1 commit into from
Aug 14, 2024
Merged

Add object selector to the shoot webhook #903

merged 1 commit into from
Aug 14, 2024

Conversation

ialidzhikov
Copy link
Member

How to categorize this PR?

/area scalability
/kind enhancement
/platform azure

What this PR does / why we need it:
Similar to gardener/gardener-extension-provider-aws#988

Which issue(s) this PR fixes:
Part of gardener/gardener#9864

Special notes for your reviewer:

Release note:

The shoot-webhook that mutates the `calico-node` DaemonSet does now specify object selector. The webhook will now intercept only requests for the `calico-node` DaemonSet.

@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jun 25, 2024
@gardener-robot gardener-robot added area/scalability Scalability related kind/enhancement Enhancement, improvement, extension platform/azure Microsoft Azure platform/infrastructure needs/review Needs review size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) needs/second-opinion Needs second review by someone else labels Jun 25, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jun 25, 2024
@ialidzhikov ialidzhikov mentioned this pull request Jun 25, 2024
Closed
17 tasks
@gardener-robot gardener-robot added the needs/rebase Needs git rebase label Jul 22, 2024
@gardener-robot
Copy link

@ialidzhikov You need rebase this pull request with latest master branch. Please check.

@ialidzhikov ialidzhikov force-pushed the enh/shoot-webhook-object-selector branch from 8b49a4a to e5ed388 Compare August 1, 2024 07:26
@gardener-robot gardener-robot added size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) and removed size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) labels Aug 1, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Aug 1, 2024
@ialidzhikov ialidzhikov marked this pull request as ready for review August 1, 2024 07:26
@ialidzhikov ialidzhikov requested review from a team as code owners August 1, 2024 07:26
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Aug 1, 2024
LucaBernstein
LucaBernstein reviewed Aug 1, 2024
View reviewed changes
Copy link
Member

@LucaBernstein LucaBernstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/rebase Needs git rebase needs/review Needs review needs/second-opinion Needs second review by someone else labels Aug 1, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Aug 1, 2024
@AndreasBurger AndreasBurger merged commit 4a71ea6 into gardener:master Aug 14, 2024
17 checks passed
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Aug 14, 2024
@ialidzhikov ialidzhikov deleted the enh/shoot-webhook-object-selector branch August 15, 2024 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LucaBernstein LucaBernstein LucaBernstein left review comments

@AndreasBurger AndreasBurger AndreasBurger approved these changes

Assignees
No one assigned
Labels
area/scalability Scalability related kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) platform/azure Microsoft Azure platform/infrastructure reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@ialidzhikov @gardener-robot @AndreasBurger @LucaBernstein @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3