Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add object selector to controlplane webhook with version constraint #905

Merged
merged 1 commit into from
Aug 5, 2024
Merged

Add object selector to controlplane webhook with version constraint #905

merged 1 commit into from
Aug 5, 2024

Conversation

LucaBernstein
Copy link
Member

@LucaBernstein LucaBernstein commented Jun 25, 2024 •
edited
Loading

How to categorize this PR?

/area control-plane
/kind enhancement
/platform azure

What this PR does / why we need it:
Part of issue gardener/gardener#9864, followup for g/g PR #9981. Use ObjectSelector in controlplane webhook to limit mutator calls for unrelated resource changes.

Which issue(s) this PR fixes:
Part of #9864

Special notes for your reviewer:

Release note:

Starting with gardenlet >= v1.98.0, use controlplane webhook object selector to limit mutator calls.

@gardener-robot gardener-robot added area/control-plane Control plane related kind/enhancement Enhancement, improvement, extension platform/azure Microsoft Azure platform/infrastructure needs/review Needs review labels Jun 25, 2024
@LucaBernstein LucaBernstein mentioned this pull request Jun 25, 2024
Closed
17 tasks
@gardener-robot gardener-robot added size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) needs/second-opinion Needs second review by someone else labels Jun 25, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jun 25, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jun 25, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jun 25, 2024
@gardener-robot gardener-robot added the needs/rebase Needs git rebase label Jul 22, 2024
@gardener-robot
Copy link

@LucaBernstein You need rebase this pull request with latest master branch. Please check.

@LucaBernstein LucaBernstein force-pushed the controlplane-extension-webhook-object-selector branch from e300de4 to cd074e7 Compare July 31, 2024 15:08
@LucaBernstein LucaBernstein marked this pull request as ready for review July 31, 2024 15:08
@LucaBernstein LucaBernstein requested review from a team as code owners July 31, 2024 15:08
@gardener-robot gardener-robot added the size/s Size of pull request is small (see gardener-robot robot/bots/size.py) label Jul 31, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 31, 2024
@gardener-robot gardener-robot removed the size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) label Jul 31, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 31, 2024
@LucaBernstein LucaBernstein force-pushed the controlplane-extension-webhook-object-selector branch from cd074e7 to 635db98 Compare August 2, 2024 09:03
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Aug 2, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Aug 2, 2024
ialidzhikov
ialidzhikov approved these changes Aug 2, 2024
View reviewed changes
Copy link
Member

@ialidzhikov ialidzhikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/rebase Needs git rebase labels Aug 2, 2024
@gardener-robot gardener-robot removed needs/review Needs review needs/second-opinion Needs second review by someone else labels Aug 2, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Aug 2, 2024
@LucaBernstein LucaBernstein merged commit aa32bea into gardener:master Aug 5, 2024
15 checks passed
@LucaBernstein LucaBernstein deleted the controlplane-extension-webhook-object-selector branch August 5, 2024 07:46
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ialidzhikov ialidzhikov ialidzhikov approved these changes

Assignees
No one assigned
Labels
area/control-plane Control plane related kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) platform/azure Microsoft Azure platform/infrastructure reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/s Size of pull request is small (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@LucaBernstein @gardener-robot @ialidzhikov @gardener-robot-ci-1 @gardener-robot-ci-3