Make infra-flow deletion more resilient #925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've recently seen a few edge cases where some referenced resources were already successfully deleted but the deletion flow was not finished completely. Upon retry the deletion was now stuck since the supposedly still existing resources could not be found anymore. With this commit, those resources will be assumed to have been successfully deleted and the deletion flow will continue.
gardener-robot
added
area/robustness
gardener-robot-ci-3
added
reviewed/ok-to-test
kon-angelo
requested changes
Jul 26, 2024
Comment on lines
807
to
811
| err = client.FilterNotFoundError(err) | ||
|
|
||
| if err != nil { | ||
| return err | ||
| } |
There was a problem hiding this comment.
if client.FilterNotFoundError(err) {
return err
}
|
|
||
| // If we do not find any loadbalancers, assume the resource group was successfully deleted and we | ||
| // are done. | ||
| err = client.FilterNotFoundError(err) |
gardener-robot-ci-1
added
the
reviewed/ok-to-test
gardener-robot-ci-2
removed
the
reviewed/ok-to-test
gardener-robot
added
reviewed/lgtm
gardener-robot-ci-2
added
the
reviewed/ok-to-test
gardener-robot
added
the
status/closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area robustness
/kind enhancement
/platform azure
What this PR does / why we need it:
We've recently seen a few edge cases where some referenced resources were already successfully deleted but the deletion flow was not finished completely. Upon retry the deletion was now stuck since the supposedly still existing resources could not be found anymore.
This PR makes the deletion more resilient against these cases.
Special notes for your reviewer:
Release note: