Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Release v1.46] Default to Public Azure Instance in DNSRecord Actuator #938

Merged
merged 1 commit into from
Aug 12, 2024
Merged

[Release v1.46] Default to Public Azure Instance in DNSRecord Actuator #938

merged 1 commit into from
Aug 12, 2024

Conversation

AndreasBurger
Copy link
Member

How to categorize this PR?

/area control-plane
/kind enhancement
/platform azure

What this PR does / why we need it:
The DNSRecord Actuator will now default to the Public Azure instance if no other information is available as (unlike for our other actuators) the required information is not guaranteed to be available.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

DNSRecord Actuator client will now default to the public Azure cloud if no explicit config is given (instead of failing)

@AndreasBurger AndreasBurger requested review from a team as code owners August 12, 2024 12:16
@gardener-robot gardener-robot added area/control-plane Control plane related kind/enhancement Enhancement, improvement, extension platform/azure Microsoft Azure platform/infrastructure needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Aug 12, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Aug 12, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Aug 12, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Aug 12, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Aug 12, 2024
hebelsan
hebelsan approved these changes Aug 12, 2024
View reviewed changes
Copy link
Contributor

@hebelsan hebelsan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Aug 12, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Aug 12, 2024
@AndreasBurger AndreasBurger merged commit 709f275 into gardener:release-v1.46 Aug 12, 2024
13 checks passed
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Aug 12, 2024
@AndreasBurger AndreasBurger deleted the dns-actuator-default branch August 12, 2024 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hebelsan hebelsan hebelsan approved these changes

Assignees
No one assigned
Labels
area/control-plane Control plane related kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) platform/azure Microsoft Azure platform/infrastructure reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@AndreasBurger @hebelsan @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot