Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

conditionally enable allow-egress LBs #958

Merged
merged 6 commits into from
Oct 7, 2024
Merged

conditionally enable allow-egress LBs #958

merged 6 commits into from
Oct 7, 2024

Conversation

kon-angelo
Copy link
Contributor

How to categorize this PR?

/area control-plane
/kind enhancement
/platform azure

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

Conditionally enable allow-egress-{tcp,udp} loadbalancers.

@kon-angelo kon-angelo requested review from a team as code owners September 6, 2024 17:19
@kon-angelo
Copy link
Contributor Author

/test

@gardener-robot gardener-robot added kind/api-change API change with impact on API users needs/second-opinion Needs second review by someone else labels Sep 6, 2024
@testmachinery
Copy link

testmachinery bot commented Sep 6, 2024 •
edited
Loading

Testrun: e2e-kx9wt
Workflow: e2e-kx9wt-wf
Phase: Failed

+---------------------+---------------------------+-----------+----------+
|        NAME         |           STEP            |   PHASE   | DURATION |
+---------------------+---------------------------+-----------+----------+
| bastion-test        | bastion-test              | Succeeded | 8m7s     |
| infrastructure-test | infrastructure-test       | Failed    | 35m6s    |
| infrastructure-test | infra-flow-test           | Omitted   | 0s       |
| infrastructure-test | infra-flow-migration-test | Omitted   | 0s       |
+---------------------+---------------------------+-----------+----------+

@gardener-robot gardener-robot added area/control-plane Control plane related kind/enhancement Enhancement, improvement, extension platform/azure Microsoft Azure platform/infrastructure needs/review Needs review size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) labels Sep 6, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Sep 6, 2024
@kon-angelo
Copy link
Contributor Author

/test

@testmachinery
Copy link

testmachinery bot commented Sep 9, 2024 •
edited
Loading

Testrun: e2e-ckmwp
Workflow: e2e-ckmwp-wf
Phase: Failed

+---------------------+---------------------------+-----------+----------+
|        NAME         |           STEP            |   PHASE   | DURATION |
+---------------------+---------------------------+-----------+----------+
| bastion-test        | bastion-test              | Succeeded | 8m2s     |
| infrastructure-test | infrastructure-test       | Failed    | 48m15s   |
| infrastructure-test | infra-flow-migration-test | Omitted   | 0s       |
| infrastructure-test | infra-flow-test           | Omitted   | 0s       |
+---------------------+---------------------------+-----------+----------+

@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Sep 9, 2024
@kon-angelo
Copy link
Contributor Author

/test

@testmachinery
Copy link

testmachinery bot commented Sep 9, 2024 •
edited
Loading

Testrun: e2e-8g5wq
Workflow: e2e-8g5wq-wf
Phase: Failed

+---------------------+---------------------------+-----------+----------+
|        NAME         |           STEP            |   PHASE   | DURATION |
+---------------------+---------------------------+-----------+----------+
| bastion-test        | bastion-test              | Succeeded | 8m20s    |
| infrastructure-test | infrastructure-test       | Failed    | 33m0s    |
| infrastructure-test | infra-flow-test           | Omitted   | 0s       |
| infrastructure-test | infra-flow-migration-test | Omitted   | 0s       |
+---------------------+---------------------------+-----------+----------+

@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 9, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 9, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Sep 9, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 9, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 9, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Oct 4, 2024
@kon-angelo
Copy link
Contributor Author

/test

@testmachinery
Copy link

testmachinery bot commented Oct 4, 2024 •
edited
Loading

Testrun: e2e-rp5f5
Workflow: e2e-rp5f5-wf
Phase: Succeeded

+---------------------+---------------------------+-----------+----------+
|        NAME         |           STEP            |   PHASE   | DURATION |
+---------------------+---------------------------+-----------+----------+
| infrastructure-test | infra-flow-migration-test | Succeeded | 33m11s   |
| bastion-test        | bastion-test              | Succeeded | 8m17s    |
| infrastructure-test | infrastructure-test       | Succeeded | 29m50s   |
| infrastructure-test | infra-flow-test           | Succeeded | 28m30s   |
+---------------------+---------------------------+-----------+----------+

@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Oct 4, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Oct 4, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Oct 4, 2024
@kon-angelo
Copy link
Contributor Author

@AndreasBurger PTAL :)

@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Oct 4, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Oct 4, 2024
hebelsan
hebelsan previously approved these changes Oct 4, 2024
View reviewed changes
Copy link
Contributor

@hebelsan hebelsan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review needs/second-opinion Needs second review by someone else labels Oct 4, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Oct 4, 2024
@kon-angelo @hebelsan
comment typos
22b679b 
Co-authored-by: Alexander Hebel <alexander.hebel@sap.com>
@gardener-robot gardener-robot added needs/review Needs review needs/second-opinion Needs second review by someone else and removed needs/review Needs review reviewed/lgtm Has approval for merging labels Oct 7, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Oct 7, 2024
@kon-angelo kon-angelo merged commit ef48ef1 into gardener:master Oct 7, 2024
13 checks passed
@kon-angelo kon-angelo deleted the disable-allow-egress branch October 7, 2024 08:13
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hebelsan hebelsan hebelsan approved these changes

@AndreasBurger AndreasBurger AndreasBurger left review comments

Assignees
No one assigned
Labels
area/control-plane Control plane related kind/api-change API change with impact on API users kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/second-opinion Needs second review by someone else platform/azure Microsoft Azure platform/infrastructure size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@kon-angelo @AndreasBurger @hebelsan @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot