Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix nil pointer dereference #975

Merged
merged 1 commit into from
Sep 30, 2024
Merged

Fix nil pointer dereference #975

merged 1 commit into from
Sep 30, 2024

Conversation

hebelsan
Copy link
Contributor

How to categorize this PR?

/area quality
/kind bug
/platform azure

What this PR does / why we need it:
Fix nil pointer dereference if diagnostic profile without given storage URI is used.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

Fix nil pointer dereference if diagnostic profile without given storage URI is used.

@hebelsan hebelsan requested review from a team as code owners September 30, 2024 13:38
@gardener-robot gardener-robot added needs/review Needs review area/quality Output qualification (tests, checks, scans, automation in general, etc.) related kind/bug Bug platform/azure Microsoft Azure platform/infrastructure size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Sep 30, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 30, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Sep 30, 2024
kon-angelo
kon-angelo approved these changes Sep 30, 2024
View reviewed changes
Copy link
Contributor

@kon-angelo kon-angelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Sep 30, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 30, 2024
@hebelsan hebelsan merged commit 05d6831 into gardener:master Sep 30, 2024
19 checks passed
@hebelsan hebelsan deleted the fix-diag-profile branch September 30, 2024 13:50
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kon-angelo kon-angelo kon-angelo approved these changes

Assignees
No one assigned
Labels
area/quality Output qualification (tests, checks, scans, automation in general, etc.) related kind/bug Bug needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) platform/azure Microsoft Azure platform/infrastructure reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hebelsan @kon-angelo @gardener-robot-ci-1 @gardener-robot-ci-3 @gardener-robot