Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix "make test" on macOS #197

Merged
merged 1 commit into from
Nov 11, 2020
Merged

Fix "make test" on macOS #197

merged 1 commit into from
Nov 11, 2020

Conversation

ialidzhikov
Copy link
Member

How to categorize this PR?

/area dev-productivity
/kind bug
/priority normal
/platform gcp

What this PR does / why we need it:
Currently make test fails on macOS - see #183 (comment). The issue is fixed on github.com/gobuffalo/packr/v2 side with gobuffalo/packr#284.

Release note:

An issue causing `make test` to fail on macOS is now fixed.

@ialidzhikov
Fix "make test" on macOS
89c107c 
Signed-off-by: ialidzhikov <i.alidjikov@gmail.com>
@ialidzhikov ialidzhikov requested review from a team as code owners November 10, 2020 18:37
@gardener-robot gardener-robot added area/dev-productivity Developer productivity related (how to improve development) kind/bug Bug platform/gcp Google cloud platform/infrastructure priority/normal needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Nov 10, 2020
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 10, 2020
vpnachev
vpnachev reviewed Nov 10, 2020
View reviewed changes
Copy link
Member

@vpnachev vpnachev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Nov 10, 2020
vpnachev
vpnachev approved these changes Nov 10, 2020
View reviewed changes
Copy link
Member

@vpnachev vpnachev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

prashanth26
prashanth26 approved these changes Nov 11, 2020
View reviewed changes
Copy link

@prashanth26 prashanth26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@dkistner
Copy link
Member

/lgtm

@dkistner dkistner merged commit a6be606 into gardener:master Nov 11, 2020
@ialidzhikov ialidzhikov deleted the fix/make-test-on-macos branch November 21, 2020 17:05
@gardener-robot gardener-robot added priority/3 Priority (lower number equals higher priority) and removed priority/3 Priority (lower number equals higher priority) labels Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vpnachev vpnachev vpnachev approved these changes

@prashanth26 prashanth26 prashanth26 approved these changes

Assignees
No one assigned
Labels
area/dev-productivity Developer productivity related (how to improve development) kind/bug Bug needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) platform/gcp Google cloud platform/infrastructure reviewed/lgtm Has approval for merging size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ialidzhikov @dkistner @vpnachev @prashanth26 @gardener-robot-ci-3 @gardener-robot