-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup terraformer usage #208
Conversation
ea6e1a7
to
b631b95
Compare
/test-single |
🔥 Oops, something went wrong @rfranzke Command test-single Runs a single testrun that is either specified by command line flag or in the default values The specified path is rendered as testrun and the current repository is injected as a default location. Example: /test-single [path to the testrun] Usage: --dry-run Print the rendered testrun
|
/assign @schrodit |
we are running again into rate limits: fyi @dguendisch |
b631b95
to
31c7942
Compare
Vendored the current g/g master, so as such this PR is /test-single |
Testrun: e2e-lkr6r +---------------------+---------------------+-----------+----------+ | NAME | STEP | PHASE | DURATION | +---------------------+---------------------+-----------+----------+ | infrastructure-test | infrastructure-test | Succeeded | 7m55s | +---------------------+---------------------+-----------+----------+ |
31c7942
to
e1a9a6c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
How to categorize this PR?
/area logging quality
/kind cleanup
/priority normal
/platform gcp
What this PR does / why we need it:
This PR adapts the infrastructure actuator to gardener/gardener#3223 by
logr
for terraformer usage (instead oflogrus
) which makes it consistent with the other controller logs (which already uselogr
). Now all the logging in the infrastructure controller/actuator is done vialogr
instead of a mix betweenlogr
andlogrus
.Also, it improves logging in the infrastructure actuator and test by making extensive use of the structured logging mechanisms (setting additional variables at the top level functions, which will be propagated to all logs - even to the terraformer logs), so they will be more helpful for debugging future issues.
For example:
Before:
Now:
Special notes for your reviewer:
✅ depends on gardener/gardener#3223
Release note: