Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inject ownerRef into infra secrets and configmaps #228

Merged
merged 2 commits into from
Jan 12, 2021
Merged

Inject ownerRef into infra secrets and configmaps #228

merged 2 commits into from
Jan 12, 2021

Conversation

vpnachev
Copy link
Member

How to categorize this PR?

/area quality
/kind enhancement
/priority normal
/platform gcp

What this PR does / why we need it:
Set the Infrastructure resource as owner of the secrets/configmaps used by the terraformer.
Vendors gardener/gardener@570ae17

Which issue(s) this PR fixes:
Related to gardener/gardener#3275

Special notes for your reviewer:

Release note:

The secrets and configmaps used by the terraformer now have an owner reference to the Infrastructure resource.
Golang has been updated to 1.15.5

Alpine base image has been updated to 3.12.3.

@vpnachev vpnachev requested review from a team as code owners January 12, 2021 12:20
@gardener-robot gardener-robot added needs/review Needs review area/quality Output qualification (tests, checks, scans, automation in general, etc.) related kind/enhancement Enhancement, improvement, extension platform/gcp Google cloud platform/infrastructure priority/normal size/s Size of pull request is small (see gardener-robot robot/bots/size.py) labels Jan 12, 2021
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jan 12, 2021
@vpnachev vpnachev changed the title Infra/owner ref Inject ownerRef into infra secrets and configmaps Jan 12, 2021
@kon-angelo
Copy link
Contributor

/test

@testmachinery
Copy link

testmachinery bot commented Jan 12, 2021 •
edited
Loading

Testrun: e2e-tx4dl
Workflow: e2e-tx4dl-wf
Phase: Succeeded

+---------------------+---------------------+-----------+----------+
|        NAME         |        STEP         |   PHASE   | DURATION |
+---------------------+---------------------+-----------+----------+
| infrastructure-test | infrastructure-test | Succeeded | 8m3s     |
+---------------------+---------------------+-----------+----------+

rfranzke
rfranzke approved these changes Jan 12, 2021
View reviewed changes
Copy link
Member

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Jan 12, 2021
prashanth26
prashanth26 approved these changes Jan 12, 2021
View reviewed changes
Copy link

@prashanth26 prashanth26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@vpnachev vpnachev merged commit 4f165f0 into gardener:master Jan 12, 2021
@vpnachev vpnachev deleted the infra/owner-ref branch January 12, 2021 19:46
@gardener-robot gardener-robot added priority/3 Priority (lower number equals higher priority) and removed priority/3 Priority (lower number equals higher priority) labels Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rfranzke rfranzke rfranzke approved these changes

@prashanth26 prashanth26 prashanth26 approved these changes

@kon-angelo kon-angelo kon-angelo approved these changes

Assignees
No one assigned
Labels
area/quality Output qualification (tests, checks, scans, automation in general, etc.) related kind/enhancement Enhancement, improvement, extension kind/test Test needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) platform/gcp Google cloud platform/infrastructure reviewed/lgtm Has approval for merging size/s Size of pull request is small (see gardener-robot robot/bots/size.py)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@vpnachev @kon-angelo @rfranzke @prashanth26 @gardener-robot-ci-3 @gardener-robot