-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VPA for validator/admission component #234
Conversation
What changed after #141? |
Well, you know best after you had to manually increase the resource limits yesterday in one of the landscapes, right 😉 From #141 (comment):
Hm, true, OTOH, we use VPA for basically everything and run thousands of clusters, so not sure if this component now is so special. Also, this statement is somewhat older and VPA became better in the meantime. Anyways, the feature is configurable, so if some landscape operator does not like it or it causes too much trouble then it can still be disabled and the old behaviour is preserved. Generally, offering VPA (and also enabling it by default) makes sense.
True, however, it's more critical if the statically configured resource requirements are not enough anymore and someone gets paged during the night for an incident that could have also auto-resolved via VPA. /cc @timuthy |
Can we combine this change with a secret sync on webhook start? Then we'd at least avoid a resource spike when the webhooks gets the first request after a while. |
@timuthy what do you have in mind? Simply listing all secrets on start-up? |
Yes, I think this will do the trick. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Thanks for this.
2645570
to
9a5bd5e
Compare
9a5bd5e
to
81b8270
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
How to categorize this PR?
/area scalability auto-scaling
/kind enhancement
/priority normal
/platform gcp
What this PR does / why we need it:
VPA for validator/admission component
Release note: