Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for Kubernetes v1.21 #255

Merged
merged 4 commits into from
Apr 19, 2021
Merged

Support for Kubernetes v1.21 #255

merged 4 commits into from
Apr 19, 2021

Conversation

rfranzke
Copy link
Member

@rfranzke rfranzke commented Apr 9, 2021 •
edited
Loading

How to categorize this PR?

/area open-source usability
/kind enhancement
/priority 3
/platform gcp
/exp intermediate
/topology garden seed shoot

What this PR does / why we need it:
This PR adds support for 1.21 to the extension.

Which issue(s) this PR fixes:
Part of gardener/gardener#3851

Special notes for your reviewer:

  • ✅ Depends on Support for Kubernetes v1.21 gardener#3860
  • I have successfully validated the functionality as follows:
    • ✅ Create new clusters with versions < 1.21
    • ✅ Create new clusters with version = 1.21
    • ✅ Upgrade old clusters from version 1.20 to version 1.21
    • ✅ Delete clusters with versions < 1.21
    • ✅ Delete clusters with version = 1.21

Release note:

The GCP extension does now support shoot clusters with Kubernetes version 1.21. You should consider the [Kubernetes release notes](https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG/CHANGELOG-1.21.md) before upgrading to 1.21.

@gardener-robot gardener-robot added area/open-source Open Source (community, enablement, contributions, conferences, CNCF, etc.) related area/usability Usability related exp/intermediate Issue that requires some project experience kind/enhancement Enhancement, improvement, extension platform/gcp Google cloud platform/infrastructure priority/3 Priority (lower number equals higher priority) topology/garden Affects Garden clusters topology/seed Affects Seed clusters topology/shoot Affects Shoot clusters needs/review Needs review size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) labels Apr 9, 2021
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Apr 9, 2021
@rfranzke
Revendor gardener/gardener to support 1.21 K8s client creation
8697c7f
@rfranzke
Add Kubernetes 1.21 support to README.md
7ff57a7
@rfranzke
Upgrade github.com/gardener/cloud-provider-gcp
71f75c6 
```feature dependency github.com/gardener/cloud-provider-gcp $56c687c74d3865b0d27e420ee0e1b5f0b1d3bce5
`k8s.io/legacy-cloud-providers` is now updated to `v0.21.0`.
```

```improvement developer github.com/gardener/cloud-provider-gcp $880405b8ba378908fc1d910b18d41d49b2e00a62
The alpine version has been updated to `v3.13.4`.
```

```improvement developer github.com/gardener/cloud-provider-gcp $880405b8ba378908fc1d910b18d41d49b2e00a62
The Golang version has been updated to `v1.16.3`.
```
@rfranzke
Use InTreePluginGCEUnregister instead of CSIMigrationGCEComplete for …
39abe31 
…Kubernetes >= 1.21

See for more details: kubernetes/kubernetes#98243
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 14, 2021
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 14, 2021
@rfranzke
Copy link
Member Author

/ready

@gardener-robot gardener-robot marked this pull request as ready for review April 14, 2021 08:26
@gardener-robot gardener-robot requested review from a team as code owners April 14, 2021 08:26
@prashanth26
Copy link

/assign

prashanth26
prashanth26 approved these changes Apr 15, 2021
View reviewed changes
Copy link

@prashanth26 prashanth26 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @rfranzke. Changes look good to me. I will do a final round of tests during the release validation.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Apr 15, 2021
@prashanth26
Copy link

/test

@testmachinery
Copy link

testmachinery bot commented Apr 15, 2021 •
edited
Loading

Testrun: e2e-m57vp
Workflow: e2e-m57vp-wf
Phase: Succeeded

+---------------------+---------------------+-----------+----------+
|        NAME         |        STEP         |   PHASE   | DURATION |
+---------------------+---------------------+-----------+----------+
| infrastructure-test | infrastructure-test | Succeeded | 9m31s    |
+---------------------+---------------------+-----------+----------+

@rfranzke
Copy link
Member Author

Shall we merge then?

@prashanth26 prashanth26 merged commit c103cab into master Apr 19, 2021
@prashanth26
Copy link

Yes done.

@prashanth26 prashanth26 deleted the kubernetes-v1.21 branch April 19, 2021 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prashanth26 prashanth26 prashanth26 approved these changes

Assignees

@prashanth26 prashanth26

Labels
area/open-source Open Source (community, enablement, contributions, conferences, CNCF, etc.) related area/usability Usability related exp/intermediate Issue that requires some project experience kind/enhancement Enhancement, improvement, extension kind/test Test needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) platform/gcp Google cloud platform/infrastructure priority/3 Priority (lower number equals higher priority) reviewed/lgtm Has approval for merging size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) topology/garden Affects Garden clusters topology/seed Affects Seed clusters topology/shoot Affects Shoot clusters
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rfranzke @prashanth26 @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot