Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-v1.16] Automated cherry pick of #266: Fix support for multiple .networks.cloudNAT.natIPNames #267

Merged
merged 1 commit into from
May 14, 2021
Merged

[release-v1.16] Automated cherry pick of #266: Fix support for multiple .networks.cloudNAT.natIPNames #267

merged 1 commit into from
May 14, 2021

Conversation

ialidzhikov
Copy link
Member

@ialidzhikov ialidzhikov commented May 13, 2021 •
edited
Loading

/kind bug

Cherry pick of #266 on release-v1.16.

#266: Fix support for multiple .networks.cloudNAT.natIPNames

Release note:

An issue causing Infrastructure with multiple `.networks.cloudNAT.natIPNames` to fail be reconciled is now fixed.

@ialidzhikov
Fix support for multiple .networks.cloudNAT.natIPNames
b88790f 
Signed-off-by: ialidzhikov <i.alidjikov@gmail.com>
@ialidzhikov ialidzhikov requested review from a team as code owners May 13, 2021 21:12
@gardener-robot gardener-robot added needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels May 13, 2021
@ialidzhikov ialidzhikov changed the title Automated cherry pick of #266: Fix support for multiple .networks.cloudNAT.natIPNames [release-v1.16] Automated cherry pick of #266: Fix support for multiple .networks.cloudNAT.natIPNames May 13, 2021
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels May 13, 2021
DockToFuture
DockToFuture approved these changes May 14, 2021
View reviewed changes
Copy link
Member

@DockToFuture DockToFuture left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels May 14, 2021
timebertt
timebertt approved these changes May 14, 2021
View reviewed changes
Copy link
Member

@timebertt timebertt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@timebertt timebertt merged commit f8b2e07 into gardener:release-v1.16 May 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DockToFuture DockToFuture DockToFuture approved these changes

@timebertt timebertt timebertt approved these changes

Assignees
No one assigned
Labels
kind/bug Bug needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ialidzhikov @DockToFuture @timebertt @gardener-robot-ci-2 @gardener-robot