Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use separate ManagedResource for ControlPlane CRDs #283

Merged
merged 1 commit into from
Jun 15, 2021
Merged

Use separate ManagedResource for ControlPlane CRDs #283

merged 1 commit into from
Jun 15, 2021

Conversation

ialidzhikov
Copy link
Member

/area storage
/kind enhancement
/platform gcp

Similar to gardener/gardener-extension-provider-aws#337

Part of gardener/gardener#2227

Release note:

provider-gcp is now using a separate ManagedResource for ControlPlane CRDs (`volumesnapshot` related CRDs) that are installed in the Shoot cluster to separate the deletion of CRDs from the deletion of the RBAC for controller leader election.

This version of provider-gcp requires at least Gardener v1.21.0. Before upgrading to this version of provider-gcp, make sure that you upgraded to at least Gardener v1.21.0.

@ialidzhikov
Use separate ManagedResource for ControlPlane CRDs
310dd84 
Signed-off-by: ialidzhikov <i.alidjikov@gmail.com>
@ialidzhikov ialidzhikov requested review from a team as code owners June 14, 2021 13:43
@gardener-robot gardener-robot added area/storage Storage related kind/enhancement Enhancement, improvement, extension platform/gcp Google cloud platform/infrastructure needs/review Needs review size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) needs/second-opinion Needs second review by someone else labels Jun 14, 2021
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jun 14, 2021
rfranzke
rfranzke approved these changes Jun 15, 2021
View reviewed changes
Copy link
Member

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review needs/second-opinion Needs second review by someone else labels Jun 15, 2021
kon-angelo
kon-angelo approved these changes Jun 15, 2021
View reviewed changes
Copy link
Contributor

@kon-angelo kon-angelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kon-angelo kon-angelo merged commit fcc4cf8 into gardener:master Jun 15, 2021
@timebertt timebertt mentioned this pull request Feb 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kon-angelo kon-angelo kon-angelo approved these changes

@rfranzke rfranzke rfranzke approved these changes

Assignees
No one assigned
Labels
area/storage Storage related kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) platform/gcp Google cloud platform/infrastructure reviewed/lgtm Has approval for merging size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ialidzhikov @rfranzke @kon-angelo @gardener-robot-ci-3 @gardener-robot