-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revendor g/g to 1.26 #290
Revendor g/g to 1.26 #290
Conversation
Co-authored-by: Marco Voelz <marco.voelz@sap.com>
/test |
Testrun: e2e-rftfq +---------------------+---------------------+-----------+----------+ | NAME | STEP | PHASE | DURATION | +---------------------+---------------------+-----------+----------+ | infrastructure-test | infrastructure-test | Succeeded | 9m24s | +---------------------+---------------------+-----------+----------+ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are unsure whether to remove the replace directive for the package above.
I think you can keep it.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@timebertt Asked the other way around - can we also remove it? As adapting the replace directive when the controllerruntime package is updated is an additional manual step which can be forgotten. |
I'm not sure, TBH.
leaves me with this diff for
so I assume, there must be some transitive dependencies using |
We're thinking about removing this |
Co-authored-by: Marco Voelz marco.voelz@sap.com
Special notes for your reviewer:
In the go.mod file we saw after
make revendor
that the following was removedWe are unsure whether to remove the replace directive for the package above.
When removing it the code stays the same only the go.sum and vendor/modules.txt changes to include older versions of that package.
WDYT?
Release note: