Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-v1.19] Automated cherry pick of #331: Fix config validation of NAT IP addresses #332

Merged
merged 1 commit into from
Sep 30, 2021
Merged

[release-v1.19] Automated cherry pick of #331: Fix config validation of NAT IP addresses #332

merged 1 commit into from
Sep 30, 2021

Conversation

stoyanr
Copy link
Contributor

@stoyanr stoyanr commented Sep 30, 2021

/area/networking
/kind/bug
/kind/test

Cherry pick of #331 on release-v1.19.

#331: Fix config validation of NAT IP addresses

Release Notes:

The cloud NAT IP validation has been fixed to correctly recognise if the external IP address is in use by the shoot's router.

@stoyanr stoyanr requested review from a team as code owners September 30, 2021 12:59
@gardener-robot gardener-robot added area/networking Networking related kind/bug Bug kind/test Test needs/review Needs review size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) labels Sep 30, 2021
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 30, 2021
@stoyanr
Copy link
Contributor Author

stoyanr commented Sep 30, 2021

/invite @ialidzhikov @kon-angelo

@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Sep 30, 2021
ialidzhikov
ialidzhikov approved these changes Sep 30, 2021
View reviewed changes
Copy link
Member

@ialidzhikov ialidzhikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Sep 30, 2021
kon-angelo
kon-angelo approved these changes Sep 30, 2021
View reviewed changes
Copy link
Contributor

@kon-angelo kon-angelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@stoyanr stoyanr merged commit 5048428 into gardener:release-v1.19 Sep 30, 2021
@stoyanr stoyanr deleted the automated-cherry-pick-of-#331-upstream-release-v1.19 branch September 30, 2021 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ialidzhikov ialidzhikov ialidzhikov approved these changes

@kon-angelo kon-angelo kon-angelo approved these changes

Assignees
No one assigned
Labels
area/networking Networking related kind/bug Bug kind/test Test needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/m Size of pull request is medium (see gardener-robot robot/bots/size.py)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@stoyanr @ialidzhikov @kon-angelo @gardener-robot-ci-1 @gardener-robot