Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace the rewrite_tag with modify one when exposing logs to end-user #338

Merged
merged 1 commit into from
Oct 20, 2021
Merged

Replace the rewrite_tag with modify one when exposing logs to end-user #338

merged 1 commit into from
Oct 20, 2021

Conversation

vlvasilev
Copy link
Contributor

@vlvasilev vlvasilev commented Oct 20, 2021 •
edited
Loading

How to categorize this PR?

/area logging
/kind enhancement
/platform gcp

What this PR does / why we need it:
This PR removes the rewrite_tag filter in the logging configuration, which is replaced by modify one.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

The `rewrite_tag` filter in the logging configuration is replaced by `modify` one

@vlvasilev vlvasilev requested review from a team as code owners October 20, 2021 05:57
@gardener-robot gardener-robot added the needs/review Needs review label Oct 20, 2021
@gardener-robot
Copy link

@vlvasilev Label kind/enhacment does not exist.

@gardener-robot gardener-robot added area/logging Logging related platform/gcp Google cloud platform/infrastructure size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Oct 20, 2021
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Oct 20, 2021
@gardener-robot gardener-robot added the kind/enhancement Enhancement, improvement, extension label Oct 20, 2021
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Oct 20, 2021
kon-angelo
kon-angelo approved these changes Oct 20, 2021
View reviewed changes
Copy link
Contributor

@kon-angelo kon-angelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Oct 20, 2021
@kon-angelo kon-angelo merged commit 81c5330 into gardener:master Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kon-angelo kon-angelo kon-angelo approved these changes

Assignees
No one assigned
Labels
area/logging Logging related kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) platform/gcp Google cloud platform/infrastructure reviewed/lgtm Has approval for merging size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vlvasilev @gardener-robot @kon-angelo @gardener-robot-ci-1 @gardener-robot-ci-2