-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make admission check of min worker pool and number of zones backward compatible #352
Make admission check of min worker pool and number of zones backward compatible #352
Conversation
b9df56b
to
b3744af
Compare
/invite @AxiomSamarth |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/ping @gardener/gardener-extension-provider-gcp-maintainers |
/assign |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally lgtm. I have only 1 minor suggestion/question.
…e to get the old worker
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
….worker validation error #352: Make admission check of min worker pool and number of zones backward compatible (#354) * Clarify autoscaling validation error * Make admission check of min worker pool and number of zones backward compatible * Use github.com/gardener/gardener/pkg/apis/core/helper.FindWorkerByName to get the old worker Co-authored-by: Plamen Kokanov <plamen.kokanov@sap.com>
How to categorize this PR?
/area ops-productivity quality robustness usability
/kind bug
/platform gcp
What this PR does / why we need it:
Make admission check of min worker pool and number of zones backward compatible
Which issue(s) this PR fixes:
Fixes #351
Special notes for your reviewer:
Release note: