Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove GCPMachineClass cleanup #360

Merged
merged 1 commit into from
Dec 14, 2021
Merged

Remove GCPMachineClass cleanup #360

merged 1 commit into from
Dec 14, 2021

Conversation

kon-angelo
Copy link
Contributor

How to categorize this PR?

/area control-plane
/kind cleanup
/platform gcp

What this PR does / why we need it:
Removes cleanup logic for deprecated GCPMachineClass objects

Special notes for your reviewer:

Release note:

Removed cleanup logic for GCPMachineClass objects.

@kon-angelo kon-angelo requested review from a team as code owners December 6, 2021 20:11
@gardener-robot gardener-robot added area/control-plane Control plane related kind/cleanup Something that is not needed anymore and can be cleaned up platform/gcp Google cloud platform/infrastructure needs/review Needs review size/s Size of pull request is small (see gardener-robot robot/bots/size.py) labels Dec 6, 2021
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 6, 2021
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Dec 6, 2021
dkistner
dkistner approved these changes Dec 7, 2021
View reviewed changes
Copy link
Member

@dkistner dkistner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Dec 7, 2021
@rfranzke rfranzke merged commit 75d748f into gardener:master Dec 14, 2021
@kon-angelo kon-angelo deleted the remove-gcpmc-cleanup branch February 29, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkistner dkistner dkistner approved these changes

Assignees
No one assigned
Labels
area/control-plane Control plane related kind/cleanup Something that is not needed anymore and can be cleaned up needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) platform/gcp Google cloud platform/infrastructure reviewed/lgtm Has approval for merging size/s Size of pull request is small (see gardener-robot robot/bots/size.py)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@kon-angelo @dkistner @rfranzke @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot