-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for sa token volume projection in the admission charts #380
Add support for sa token volume projection in the admission charts #380
Conversation
@dimityrmirchev Label kind/feature does not exist. |
21d6f3c
to
18fa956
Compare
/invite @vpnachev @rfranzke @timebertt |
/assign |
charts/gardener-extension-admission-gcp/charts/runtime/templates/deployment.yaml
Show resolved
Hide resolved
charts/gardener-extension-admission-gcp/charts/runtime/templates/serviceaccount.yaml
Show resolved
Hide resolved
charts/gardener-extension-admission-gcp/charts/runtime/templates/deployment.yaml
Outdated
Show resolved
Hide resolved
charts/gardener-extension-admission-gcp/charts/runtime/templates/deployment.yaml
Outdated
Show resolved
Hide resolved
I left out the ability to configure an already existing "generic" kubeconfig for now as the current changes will not expand the etcd size. If this becomes something that we want to chase I can contribute it in a different set of PRs, but I guess for now priority is the actual functionality. |
Converted to draft since there are some changes still needed. |
c42a2a2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
How to categorize this PR?
/area security
/kind enhancement
/platform gcp
What this PR does / why we need it:
This PR adds:
clusterrolebinding
definition when using a "virtual garden" setup. This will enable other possibilities for authentication to the virtual garden, i.e., leveraging oidc-webhook-authenticator.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
If this gets approved I will open similar PRs for the other extensions.
Release note: