Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add object selector for provider type in the gardener-extension-admission-gcp webhook #397

Merged
merged 2 commits into from
Mar 8, 2022
Merged

Add object selector for provider type in the gardener-extension-admission-gcp webhook #397

merged 2 commits into from
Mar 8, 2022

Conversation

shafeeqes
Copy link
Contributor

@shafeeqes shafeeqes commented Feb 25, 2022 •
edited
Loading

How to categorize this PR?

/area robustness
/kind enhancement
/platform gcp

What this PR does / why we need it:
This PR adds an object selector for provider type label in the gardener-extension-admission-gcp webhook. This helps in filtering out only resources having provider type gcp for validation.

Which issue(s) this PR fixes:
Fixes part of gardener/gardener#4932

Special notes for your reviewer:
Related to gardener/gardener#5472

Release note:

The `gardener-extension-admission-gcp` webhook now contains an object selector for provider type label. Please make sure you are running `gardener@v1.42` or later before enabling the same.

@gardener-robot gardener-robot added area/robustness Robustness, reliability, resilience related kind/enhancement Enhancement, improvement, extension platform/gcp Google cloud platform/infrastructure needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Feb 25, 2022
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Feb 25, 2022
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Feb 25, 2022
@shafeeqes shafeeqes force-pushed the enhancement/AdmissionWebhooks branch from c5674f3 to d1872b7 Compare March 2, 2022 18:02
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 2, 2022
@shafeeqes shafeeqes marked this pull request as ready for review March 2, 2022 18:03
@shafeeqes shafeeqes requested review from a team as code owners March 2, 2022 18:03
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 2, 2022
@shafeeqes shafeeqes force-pushed the enhancement/AdmissionWebhooks branch from d1872b7 to e44de2d Compare March 3, 2022 05:32
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 3, 2022
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 3, 2022
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Mar 3, 2022
rfranzke
rfranzke approved these changes Mar 3, 2022
View reviewed changes
Copy link
Member

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Mar 3, 2022
@rfranzke rfranzke merged commit 76a57ca into gardener:master Mar 8, 2022
@shafeeqes shafeeqes deleted the enhancement/AdmissionWebhooks branch March 29, 2022 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rfranzke rfranzke rfranzke approved these changes

Assignees
No one assigned
Labels
area/robustness Robustness, reliability, resilience related kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) platform/gcp Google cloud platform/infrastructure reviewed/lgtm Has approval for merging size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@shafeeqes @rfranzke @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot