Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use projected token mount for terraformer #399

Merged
merged 1 commit into from
Mar 14, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions cmd/gardener-extension-provider-gcp/app/app.go
Original file line number Diff line number Diff line change
Expand Up @@ -194,6 +194,7 @@ func NewControllerManagerCommand(ctx context.Context) *cobra.Command {
controllercmd.LogErrAndExit(err, "Could not determine whether service account token volume projection should be used")
}
gcpcontrolplane.DefaultAddOptions.UseProjectedTokenMount = useProjectedTokenMount
gcpinfrastructure.DefaultAddOptions.UseProjectedTokenMount = useProjectedTokenMount
gcpworker.DefaultAddOptions.UseProjectedTokenMount = useProjectedTokenMount

configFileOpts.Completed().ApplyETCDStorage(&gcpcontrolplaneexposure.DefaultAddOptions.ETCDStorage)
Expand Down
6 changes: 4 additions & 2 deletions pkg/controller/infrastructure/actuator.go
Original file line number Diff line number Diff line change
Expand Up @@ -33,12 +33,14 @@ import (
type actuator struct {
logger logr.Logger
common.RESTConfigContext
useProjectedTokenMount bool
}

// NewActuator creates a new infrastructure.Actuator.
func NewActuator() infrastructure.Actuator {
func NewActuator(useProjectedTokenMount bool) infrastructure.Actuator {
return &actuator{
logger: log.Log.WithName("infrastructure-actuator"),
logger: log.Log.WithName("infrastructure-actuator"),
useProjectedTokenMount: useProjectedTokenMount,
}
}

Expand Down
2 changes: 1 addition & 1 deletion pkg/controller/infrastructure/actuator_delete.go
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ func (a *actuator) cleanupKubernetesRoutes(
func (a *actuator) Delete(ctx context.Context, infra *extensionsv1alpha1.Infrastructure, cluster *controller.Cluster) error {
logger := a.logger.WithValues("infrastructure", client.ObjectKeyFromObject(infra), "operation", "delete")

tf, err := internal.NewTerraformer(logger, a.RESTConfig(), infrastructure.TerraformerPurpose, infra)
tf, err := internal.NewTerraformer(logger, a.RESTConfig(), infrastructure.TerraformerPurpose, infra, a.useProjectedTokenMount)
if err != nil {
return err
}
Expand Down
2 changes: 1 addition & 1 deletion pkg/controller/infrastructure/actuator_migrate.go
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ import (
func (a *actuator) Migrate(ctx context.Context, infra *extensionsv1alpha1.Infrastructure, cluster *controller.Cluster) error {
logger := a.logger.WithValues("infrastructure", client.ObjectKeyFromObject(infra), "operation", "migrate")

tf, err := internal.NewTerraformer(logger, a.RESTConfig(), infrastructure.TerraformerPurpose, infra)
tf, err := internal.NewTerraformer(logger, a.RESTConfig(), infrastructure.TerraformerPurpose, infra, a.useProjectedTokenMount)
if err != nil {
return err
}
Expand Down
2 changes: 1 addition & 1 deletion pkg/controller/infrastructure/actuator_reconcile.go
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ func (a *actuator) reconcile(ctx context.Context, logger logr.Logger, infra *ext
return err
}

tf, err := internal.NewTerraformerWithAuth(logger, a.RESTConfig(), infrastructure.TerraformerPurpose, infra)
tf, err := internal.NewTerraformerWithAuth(logger, a.RESTConfig(), infrastructure.TerraformerPurpose, infra, a.useProjectedTokenMount)
if err != nil {
return err
}
Expand Down
4 changes: 3 additions & 1 deletion pkg/controller/infrastructure/add.go
Original file line number Diff line number Diff line change
Expand Up @@ -35,13 +35,15 @@ type AddOptions struct {
Controller controller.Options
// IgnoreOperationAnnotation specifies whether to ignore the operation annotation or not.
IgnoreOperationAnnotation bool
// UseProjectedTokenMount specifies whether the projected token mount shall be used for the terraformer.
UseProjectedTokenMount bool
}

// AddToManagerWithOptions adds a controller with the given AddOptions to the given manager.
// The opts.Reconciler is being set with a newly instantiated actuator.
func AddToManagerWithOptions(mgr manager.Manager, options AddOptions) error {
return infrastructure.Add(mgr, infrastructure.AddArgs{
Actuator: NewActuator(),
Actuator: NewActuator(options.UseProjectedTokenMount),
ConfigValidator: NewConfigValidator(gcpclient.NewFactory(), log.Log),
ControllerOptions: options.Controller,
Predicates: infrastructure.DefaultPredicates(options.IgnoreOperationAnnotation),
Expand Down
15 changes: 12 additions & 3 deletions pkg/internal/terraform.go
Original file line number Diff line number Diff line change
Expand Up @@ -54,14 +54,19 @@ func NewTerraformer(
restConfig *rest.Config,
purpose string,
infra *extensionsv1alpha1.Infrastructure,
) (terraformer.Terraformer, error) {
useProjectedTokenMount bool,
) (
terraformer.Terraformer,
error,
) {
tf, err := terraformer.NewForConfig(logger, restConfig, purpose, infra.Namespace, infra.Name, imagevector.TerraformerImage())
if err != nil {
return nil, err
}

owner := metav1.NewControllerRef(infra, extensionsv1alpha1.SchemeGroupVersion.WithKind(extensionsv1alpha1.InfrastructureResource))
return tf.
UseProjectedTokenMount(useProjectedTokenMount).
SetTerminationGracePeriodSeconds(630).
SetDeadlineCleaning(5 * time.Minute).
SetDeadlinePod(15 * time.Minute).
Expand All @@ -74,8 +79,12 @@ func NewTerraformerWithAuth(
restConfig *rest.Config,
purpose string,
infra *extensionsv1alpha1.Infrastructure,
) (terraformer.Terraformer, error) {
tf, err := NewTerraformer(logger, restConfig, purpose, infra)
useProjectedTokenMount bool,
) (
terraformer.Terraformer,
error,
) {
tf, err := NewTerraformer(logger, restConfig, purpose, infra, useProjectedTokenMount)
if err != nil {
return nil, err
}
Expand Down