Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust metric name due to upgrading the kube-state-metrics component #457

Merged
merged 1 commit into from
Aug 8, 2022

Conversation

istvanballok
Copy link
Member

@istvanballok istvanballok commented Jun 29, 2022

How to categorize this PR?

/area monitoring
/kind enhancement
/platform gcp

What this PR does / why we need it:

Adjust metric name due to upgrading the kube-state-metrics component

See gardener/gardener#6224

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

/cc @wyb1 @ialidzhikov

Release note:

Adjust metric name due to upgrading the kube-state-metrics component
This version of provider-gcp requires Gardener v1.51+. 

@istvanballok istvanballok requested review from a team as code owners June 29, 2022 13:13
@gardener-robot gardener-robot added needs/review Needs review area/monitoring Monitoring (including availability monitoring and alerting) related kind/enhancement Enhancement, improvement, extension platform/gcp Google cloud platform/infrastructure size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Jun 29, 2022
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jun 29, 2022
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jun 29, 2022
Copy link
Contributor

@kon-angelo kon-angelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Jun 29, 2022
@kon-angelo
Copy link
Contributor

@istvanballok actually we need to wait the next gardener release containing the new kube-state-metrics version right ?

/hold

@gardener-robot gardener-robot added the reviewed/do-not-merge Has no approval for merging as it may break things, be of poor quality or have (ext.) dependencies label Jun 29, 2022
Copy link

@wyb1 wyb1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@istvanballok
Copy link
Member Author

@istvanballok actually we need to wait the next gardener release containing the new kube-state-metrics version right?

Yes. Once (probably soon) the PR gardener/gardener#6224 is merged and the next gardener version is released, a new version of the extension could also be released.

If the extension is released earlier, the dashboard wouldn't show the requests and limits but it is still possible to query the corresponding information by manually adjusting the dashboards or executing those queries.

If gardener is released earlier, there is a temporary recording rule which stores the new metrics under the old names to prevent breaking the dashboards.

@istvanballok
Copy link
Member Author

actually we need to wait the next gardener release containing the new kube-state-metrics version right ?

See gardener/gardener-extension-provider-alicloud#506 (comment):
now that gardener v1.51.0 has been released, the adjustments in (all) the extensions could also be released.

Copy link
Member

@dkistner dkistner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@dkistner dkistner merged commit 856b6aa into gardener:master Aug 8, 2022
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/monitoring Monitoring (including availability monitoring and alerting) related kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) platform/gcp Google cloud platform/infrastructure reviewed/do-not-merge Has no approval for merging as it may break things, be of poor quality or have (ext.) dependencies reviewed/lgtm Has approval for merging size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants