-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust metric name due to upgrading the kube-state-metrics component #457
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@istvanballok actually we need to wait the next gardener release containing the new kube-state-metrics version right ? /hold |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Yes. Once (probably soon) the PR gardener/gardener#6224 is merged and the next gardener version is released, a new version of the extension could also be released. If the extension is released earlier, the dashboard wouldn't show the requests and limits but it is still possible to query the corresponding information by manually adjusting the dashboards or executing those queries. If gardener is released earlier, there is a temporary recording rule which stores the new metrics under the old names to prevent breaking the dashboards. |
See gardener/gardener-extension-provider-alicloud#506 (comment): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
How to categorize this PR?
/area monitoring
/kind enhancement
/platform gcp
What this PR does / why we need it:
Adjust metric name due to upgrading the kube-state-metrics component
See gardener/gardener#6224
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
/cc @wyb1 @ialidzhikov
Release note: