Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add arm support #477

Merged
merged 4 commits into from
Sep 8, 2022
Merged

Add arm support #477

merged 4 commits into from
Sep 8, 2022

Conversation

acumino
Copy link
Member

@acumino acumino commented Aug 4, 2022

How to categorize this PR?

/area delivery
/kind enhancement
/platform gcp

What this PR does / why we need it:
This PR Adds a new architecture field in WorkerStatus and CloudProfileConfig to support specifying architecture.

  • CloudProfileConfig now supports a new field .machineImages[].machineImageVersion[].architecture. It specifies the supported CPU architecture of the given machine image.
  • WorkerStatus now supports a new field .machineImage[].architecture. It specifies the supported CPU architecture of the given worker pool.

Which issue(s) this PR fixes:
Part of https://github.com/gardener/backlog/issues/19

Special notes for your reviewer:

Release note:

`CloudProfileConfig` now supports a new field `.machineImages[].machineImageVersion[].architecture`. It specifies the supported CPU architecture of the given machine image.
`WorkerStatus` now supports a new field `.machineImage[].architecture`. It specifies the supported CPU architecture of the given worker pool.

@acumino acumino requested review from a team as code owners August 4, 2022 10:57
@gardener-robot gardener-robot added kind/api-change API change with impact on API users needs/second-opinion Needs second review by someone else area/delivery Delivery related kind/enhancement Enhancement, improvement, extension platform/gcp Google cloud platform/infrastructure needs/review Needs review size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) labels Aug 4, 2022
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Aug 4, 2022
Copy link
Member

@dkistner dkistner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review needs/second-opinion Needs second review by someone else labels Aug 8, 2022
@dkistner
Copy link
Member

dkistner commented Aug 8, 2022

I guess we can safely move on as the amd64 is defaulted as architecture for all existing entries in the cloudprofile and the machine status?

@acumino
Copy link
Member Author

acumino commented Aug 8, 2022

/invite @ialidzhikov I have tested the changes. We can go ahead and merge this.

@gardener-robot gardener-robot added needs/review Needs review and removed reviewed/lgtm Has approval for merging labels Aug 8, 2022
@acumino
Copy link
Member Author

acumino commented Aug 25, 2022

/invite @rfranzke

@gardener-robot
Copy link

@rfranzke You have pull request review open invite, please check

@rfranzke
Copy link
Member

rfranzke commented Sep 6, 2022

/uninvite @rfranzke
@dkistner @kon-angelo please go ahead without me

@gardener-robot gardener-robot removed the request for review from rfranzke September 6, 2022 04:31
@dkistner dkistner merged commit dd1e8b6 into gardener:master Sep 8, 2022
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Sep 8, 2022
@acumino acumino deleted the ehc/cloudprofile branch February 20, 2023 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/delivery Delivery related kind/api-change API change with impact on API users kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review platform/gcp Google cloud platform/infrastructure size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants