Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add object selector to controlplane webhook with version constraint #789

Merged
merged 1 commit into from
Aug 13, 2024
Merged

Add object selector to controlplane webhook with version constraint #789

merged 1 commit into from
Aug 13, 2024

Conversation

LucaBernstein
Copy link
Member

How to categorize this PR?

/area control-plane
/kind enhancement
/platform gcp

What this PR does / why we need it:
Part of issue gardener/gardener#9864, followup for g/g PR #9981. Use ObjectSelector in controlplane webhook to limit mutator calls for unrelated resource changes.

Which issue(s) this PR fixes:
Part of #9864

Special notes for your reviewer:

Release note:

Starting with gardenlet >= v1.98.0, use controlplane webhook object selector to limit mutator calls.

@gardener-robot gardener-robot added area/control-plane Control plane related kind/enhancement Enhancement, improvement, extension platform/gcp Google cloud platform/infrastructure needs/review Needs review size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) labels Jun 25, 2024
@LucaBernstein LucaBernstein mentioned this pull request Jun 25, 2024
Closed
17 tasks
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jun 25, 2024
@LucaBernstein
Add object selector to controlplane webhook with version constraint
d77945d 
Inject gardener version to webhook switches
@LucaBernstein LucaBernstein force-pushed the controlplane-extension-webhook-object-selector branch from 5b0315e to d77945d Compare August 13, 2024 13:29
@LucaBernstein LucaBernstein marked this pull request as ready for review August 13, 2024 13:29
@LucaBernstein LucaBernstein requested review from a team as code owners August 13, 2024 13:29
@gardener-robot gardener-robot added the size/s Size of pull request is small (see gardener-robot robot/bots/size.py) label Aug 13, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Aug 13, 2024
@gardener-robot gardener-robot removed the size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) label Aug 13, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Aug 13, 2024
AndreasBurger
AndreasBurger approved these changes Aug 13, 2024
View reviewed changes
Copy link
Member

@AndreasBurger AndreasBurger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks

@AndreasBurger AndreasBurger added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Aug 13, 2024
@AndreasBurger AndreasBurger added this to the v1.38 milestone Aug 13, 2024
@AndreasBurger AndreasBurger merged commit 5ec70e8 into gardener:master Aug 13, 2024
7 of 13 checks passed
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Aug 13, 2024
@LucaBernstein LucaBernstein deleted the controlplane-extension-webhook-object-selector branch August 13, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndreasBurger AndreasBurger AndreasBurger approved these changes

Assignees
No one assigned
Labels
area/control-plane Control plane related kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review platform/gcp Google cloud platform/infrastructure reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/s Size of pull request is small (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
v1.38
Development

Successfully merging this pull request may close these issues.
5 participants
@LucaBernstein @AndreasBurger @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot