Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove failing preStop hook in node-driver-registrar #792

Merged

Conversation

sujeet01
Copy link
Contributor

@sujeet01 sujeet01 commented Jul 3, 2024

How to categorize this PR?
/area storage
/kind bug
/platform gcp

What this PR does / why we need it:
This PR removes the failing preStop lifecycle hook from the node-driver-registrar container in csi-driver-node daemonset.yaml. The distroless registrar image lacks /bin/sh, causing the hook to fail. Socket removal is now handled internally by the registrar, eliminating the need for the hook (see kubernetes-csi/node-driver-registrar#61).

Which issue(s) this PR fixes:
Fixes #244

Special notes for your reviewer:
Similar to kubernetes-csi/csi-driver-host-path#176
cc @afritzler

Release note:

Removed unnecessary preStop hook from `node-driver-registrar` in `csi-driver-node`, as socket removal is now handled internally by `node-driver-registrar`, resolving distroless image error.

@sujeet01 sujeet01 requested review from a team as code owners July 3, 2024 10:35
@CLAassistant
Copy link

CLAassistant commented Jul 3, 2024

CLA assistant check
All committers have signed the CLA.

@gardener-robot gardener-robot added area/storage Storage related kind/bug Bug platform/gcp Google cloud platform/infrastructure labels Jul 3, 2024
@gardener-robot
Copy link

@sujeet01 Thank you for your contribution.

@gardener-robot gardener-robot added needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Jul 3, 2024
@gardener-robot-ci-3
Copy link
Contributor

Thank you @sujeet01 for your contribution. Before I can start building your PR, a member of the organization must set the required label(s) {'reviewed/ok-to-test'}. Once started, you can check the build status in the PR checks section below.

@AndreasBurger AndreasBurger added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 4, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jul 4, 2024
@AndreasBurger AndreasBurger merged commit 7e3b773 into gardener:master Jul 4, 2024
15 checks passed
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Jul 4, 2024
@sujeet01 sujeet01 deleted the fix/remove-failing-preStop-hook branch July 4, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/storage Storage related kind/bug Bug needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review platform/gcp Google cloud platform/infrastructure size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

csi-node-driver-registrar preStopHook failing
5 participants