Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix hyperdisk specs validation #793

Merged
merged 4 commits into from
Jul 10, 2024
Merged

Fix hyperdisk specs validation #793

merged 4 commits into from
Jul 10, 2024

Conversation

hebelsan
Copy link
Contributor

@hebelsan hebelsan commented Jul 4, 2024

How to categorize this PR?

/area quality
/kind enhancement
/platform gcp

What this PR does / why we need it:
In contrast to what the gcp sdk doc states you can configure iops and throughput of disks of type hyperdisk-balanced.
Therefore this PR adjusts the validator.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

Allow configuring iops and throughput of hyperdisk-balanced disks

@hebelsan hebelsan requested review from a team as code owners July 4, 2024 14:28
@gardener-robot gardener-robot added needs/review Needs review kind/api-change API change with impact on API users needs/second-opinion Needs second review by someone else area/quality Output qualification (tests, checks, scans, automation in general, etc.) related kind/enhancement Enhancement, improvement, extension platform/gcp Google cloud platform/infrastructure size/s Size of pull request is small (see gardener-robot robot/bots/size.py) labels Jul 4, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 4, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jul 4, 2024
AndreasBurger
AndreasBurger approved these changes Jul 4, 2024
View reviewed changes
Copy link
Member

@AndreasBurger AndreasBurger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

kon-angelo
kon-angelo approved these changes Jul 10, 2024
View reviewed changes
Copy link
Contributor

@kon-angelo kon-angelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kon-angelo kon-angelo merged commit 4f8252d into gardener:master Jul 10, 2024
17 checks passed
@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging status/closed Issue is closed (either delivered or triaged) and removed needs/review Needs review needs/second-opinion Needs second review by someone else labels Jul 10, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndreasBurger AndreasBurger AndreasBurger approved these changes

@kon-angelo kon-angelo kon-angelo approved these changes

Assignees
No one assigned
Labels
area/quality Output qualification (tests, checks, scans, automation in general, etc.) related kind/api-change API change with impact on API users kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) platform/gcp Google cloud platform/infrastructure reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/s Size of pull request is small (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@hebelsan @AndreasBurger @kon-angelo @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot