Update CCM for k8s 1.31 #842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot
added
needs/review
gardener-robot-ci-1
added
reviewed/ok-to-test
AndreasBurger
commented
Sep 10, 2024
Comment on lines
40
to
42
| {{- if le (semver .Values.kubernetesVersion | (semver "1.31.0").Compare) 0 }} | ||
| command: ["/cloud-controller-manager"] | ||
| {{- end}} |
There was a problem hiding this comment.
Not entirely sure whether that is the way to go. This would work, but it is a bit unwieldy and we should remove the condition once older versions drop out of support.
However, we use ENTRYPOINT in our image whereas the upstream one uses CMD (and sets ENTRYPOINT to /go-runner), so one could be tempted to just specify CMD explicitly for both cases. However, in that case we would have to set it to /gcp-cloud-controller-manager for our images, so the conditional here would remain.
|
verify failing due to golang |
AndreasBurger
force-pushed
the
update-ccm
branch
from
9bf3709
to
f39016e
Compare
gardener-robot-ci-3
added
reviewed/ok-to-test
|
Rebased. |
kon-angelo
reviewed
Sep 12, 2024
...al/seed-controlplane/charts/cloud-controller-manager/templates/cloud-controller-manager.yaml
Outdated
Show resolved
Hide resolved
AndreasBurger
force-pushed
the
update-ccm
branch
from
f39016e
to
1851d26
Compare
gardener-robot-ci-2
added
the
reviewed/ok-to-test
gardener-robot-ci-1
removed
the
reviewed/ok-to-test
gardener-robot
added
reviewed/lgtm
gardener-robot-ci-1
added
the
reviewed/ok-to-test
gardener-robot
added
the
status/closed
ialidzhikov
added a commit
to ialidzhikov/gardener-extension-provider-gcp
that referenced
this pull request
Sep 16, 2024
The cloud-controller-manager image for K8s 1.31 was already adapted with gardener#842.
ialidzhikov
added a commit
to ialidzhikov/gardener-extension-provider-gcp
that referenced
this pull request
Sep 16, 2024
The cloud-controller-manager image for K8s 1.31 was already adapted with gardener#842.
ialidzhikov
added a commit
to ialidzhikov/gardener-extension-provider-gcp
that referenced
this pull request
Sep 27, 2024
The cloud-controller-manager image for K8s 1.31 was already adapted with gardener#842.
kon-angelo
pushed a commit
that referenced
this pull request
Oct 4, 2024
* Add Kubernetes 1.31 support to README.md * Update cloud-controller-manager images The cloud-controller-manager image for K8s 1.31 was already adapted with #842. * Adapt to the removal of the `InTreePluginGCEUnregister` feature gate * Adapt to the removal of the `PersistentVolumeLabel` admission plugin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area control-plane
/kind cleanup
/platform gcp
What this PR does / why we need it:
Updates the CCM to be used for kubernetes
1.31.0or greater to the one provided by GCP.Which issue(s) this PR fixes:
Fixes #679
Special notes for your reviewer:
see inline comment
Release note: