-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CCM for k8s 1.31 #842
Conversation
{{- if le (semver .Values.kubernetesVersion | (semver "1.31.0").Compare) 0 }} | ||
command: ["/cloud-controller-manager"] | ||
{{- end}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not entirely sure whether that is the way to go. This would work, but it is a bit unwieldy and we should remove the condition once older versions drop out of support.
However, we use ENTRYPOINT
in our image whereas the upstream one uses CMD
(and sets ENTRYPOINT
to /go-runner
), so one could be tempted to just specify CMD
explicitly for both cases. However, in that case we would have to set it to /gcp-cloud-controller-manager
for our images, so the conditional here would remain.
verify failing due to golang |
9bf3709
to
f39016e
Compare
Rebased. |
...al/seed-controlplane/charts/cloud-controller-manager/templates/cloud-controller-manager.yaml
Outdated
Show resolved
Hide resolved
f39016e
to
1851d26
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
The cloud-controller-manager image for K8s 1.31 was already adapted with gardener#842.
The cloud-controller-manager image for K8s 1.31 was already adapted with gardener#842.
The cloud-controller-manager image for K8s 1.31 was already adapted with gardener#842.
* Add Kubernetes 1.31 support to README.md * Update cloud-controller-manager images The cloud-controller-manager image for K8s 1.31 was already adapted with #842. * Adapt to the removal of the `InTreePluginGCEUnregister` feature gate * Adapt to the removal of the `PersistentVolumeLabel` admission plugin
How to categorize this PR?
/area control-plane
/kind cleanup
/platform gcp
What this PR does / why we need it:
Updates the CCM to be used for kubernetes
1.31.0
or greater to the one provided by GCP.Which issue(s) this PR fixes:
Fixes #679
Special notes for your reviewer:
see inline comment
Release note: