Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ControlPlane reconciliation for K8s < 1.19 #217

Merged
merged 1 commit into from
Feb 1, 2021

Conversation

ialidzhikov
Copy link
Member

@ialidzhikov ialidzhikov commented Jan 30, 2021

/kind bug

After #205 the ControlPlane reconciliation for K8s < 1.19 fails with:

  lastErrors:
    - description: >-
        task "Waiting until shoot control plane has been reconciled" failed:
        Error while waiting for ControlPlane shoot--foo--bar/bar
        to become ready: extension encountered error during reconciliation:
        Error reconciling controlplane: could not apply control plane chart for
        controlplane 'shoot--foo--bar/bar': could not inject
        chart 'csi-driver-controller' images: could not find image
        "csi-driver-cinder" opts runtime version v1.18.14 target version 1.18.14
      taskID: Waiting until shoot control plane has been reconciled

Although the csi-driver is deployed only for K8s > 1.19, the csi-driver-cinder image is part of the controlPlaneChart - ref https://github.com/gardener/gardener-extension-provider-openstack/blob/v1.15.0/pkg/controller/controlplane/valuesprovider.go#L173. Hence when the controlPlaneChart is being applied, it tries to find the corresponding csi-driver-cinder image even for K8s < 1.19 even though the corresponding csi chart won't be applied.
This PR contains a straightforward fix.

Release note:

NONE

Signed-off-by: ialidzhikov <i.alidjikov@gmail.com>
@ialidzhikov ialidzhikov requested review from a team as code owners January 30, 2021 14:29
@gardener-robot gardener-robot added kind/bug Bug needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Jan 30, 2021
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 30, 2021
@gardener-robot-ci-3 gardener-robot-ci-3 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jan 30, 2021
@ialidzhikov
Copy link
Member Author

/cc @dkistner @kon-angelo

Copy link
Member

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Feb 1, 2021
@kon-angelo
Copy link
Contributor

I am am doing a test run right now and I will deploy to dev once merged.

Copy link
Contributor

@kon-angelo kon-angelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kon-angelo kon-angelo merged commit 9110734 into gardener:master Feb 1, 2021
@ialidzhikov ialidzhikov deleted the fix/csi-version branch February 5, 2021 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Bug needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants