Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add max retries to repeat failed or throttled operations #222

Merged
merged 1 commit into from
Feb 19, 2021
Merged

Add max retries to repeat failed or throttled operations #222

merged 1 commit into from
Feb 19, 2021

Conversation

dkistner
Copy link
Member

@dkistner dkistner commented Feb 3, 2021 •
edited
Loading

How to categorize this PR?

/area robustness
/kind enhancement
/priority normal
/platform openstack

What this PR does / why we need it:
Add max retries for api call to retry failed or throttled operations.

Which issue(s) this PR fixes:
Fixes partly #220

Special notes for your reviewer:
Require terraformer-openstack with provider openstack v.1.37.0 integrated. See gardener/terraformer#68

Release note:

/invite @kon-angelo
cc @kayrus

@gardener-robot gardener-robot added area/robustness Robustness, reliability, resilience related kind/enhancement Enhancement, improvement, extension needs/review Needs review platform/openstack OpenStack platform/infrastructure priority/normal size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Feb 3, 2021
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Feb 3, 2021
@dkistner
Copy link
Member Author

dkistner commented Feb 3, 2021

@kayrus How many retries would you recommend as default?

@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Feb 3, 2021
@kayrus
Copy link
Contributor

kayrus commented Feb 3, 2021

How many retries would you recommend as default?

I think 10 is fine for now. In future this option should be used for OCCM/OS CSI drivers as well.

@dkistner dkistner force-pushed the update-infra-config branch from 07c67e7 to 55194fb Compare February 3, 2021 09:43
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Feb 3, 2021
@dkistner dkistner force-pushed the update-infra-config branch from 55194fb to e5b36a2 Compare February 3, 2021 09:45
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Feb 3, 2021
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Feb 3, 2021
@dkistner dkistner changed the title Update openstack infra Add max retries to repeat failed or throttled operations Feb 3, 2021
@dkistner dkistner mentioned this pull request Feb 3, 2021
Closed
@dkistner dkistner force-pushed the update-infra-config branch from e5b36a2 to a755869 Compare February 19, 2021 08:41
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Feb 19, 2021
@dkistner
Copy link
Member Author

As the new terraformer is now integrated I will remove the draft state.

@dkistner dkistner marked this pull request as ready for review February 19, 2021 08:42
@dkistner dkistner requested review from a team as code owners February 19, 2021 08:42
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Feb 19, 2021
kon-angelo
kon-angelo approved these changes Feb 19, 2021
View reviewed changes
Copy link
Contributor

@kon-angelo kon-angelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Feb 19, 2021
@dkistner dkistner merged commit d29b342 into master Feb 19, 2021
@dkistner dkistner deleted the update-infra-config branch February 19, 2021 09:46
@gardener-robot gardener-robot added priority/3 Priority (lower number equals higher priority) and removed priority/3 Priority (lower number equals higher priority) labels Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kayrus kayrus kayrus left review comments

@rfranzke rfranzke rfranzke left review comments

@kon-angelo kon-angelo kon-angelo approved these changes

Assignees
No one assigned
Labels
area/robustness Robustness, reliability, resilience related kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) platform/openstack OpenStack platform/infrastructure reviewed/lgtm Has approval for merging size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@dkistner @kayrus @rfranzke @kon-angelo @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot