Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-v1.19] Remove version constraints for lb config #292

Merged
merged 1 commit into from
May 27, 2021
Merged

[release-v1.19] Remove version constraints for lb config #292

merged 1 commit into from
May 27, 2021

Conversation

dkistner
Copy link
Member

How to categorize this PR?

/kind cleanup
/platform openstack

What this PR does / why we need it:
The version constraints for floating-subnet and floating-subnet-tags field in the cloud-provider-config to select a floating subnet to pick the floating ip for a load balancer has been removed.

Release note:

The version constraints for `floating-subnet` and `floating-subnet-tags` field in the cloud-provider-config to select a floating subnet to pick the floating ip for a load balancer has been removed.

/invite @kon-angelo
cc @RaphaelVogel

@dkistner
Remove version constraints for lb config
ed12925 
Remove the version constraints for the floating subnet selection for loadbalancers
@dkistner dkistner requested review from a team as code owners May 27, 2021 08:54
@gardener-robot gardener-robot requested a review from kon-angelo May 27, 2021 08:54
@gardener-robot gardener-robot added kind/cleanup Something that is not needed anymore and can be cleaned up needs/review Needs review platform/openstack OpenStack platform/infrastructure size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) labels May 27, 2021
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 27, 2021
@gardener-robot-ci-3 gardener-robot-ci-3 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels May 27, 2021
kon-angelo
kon-angelo approved these changes May 27, 2021
View reviewed changes
Copy link
Contributor

@kon-angelo kon-angelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels May 27, 2021
@dkistner dkistner merged commit fa9fda3 into gardener:release-v1.19 May 27, 2021
@dkistner dkistner deleted the release-v1.19-remove-lb-config-version-constraints branch May 27, 2021 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kon-angelo kon-angelo kon-angelo approved these changes

Assignees
No one assigned
Labels
kind/cleanup Something that is not needed anymore and can be cleaned up needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) platform/openstack OpenStack platform/infrastructure reviewed/lgtm Has approval for merging size/m Size of pull request is medium (see gardener-robot robot/bots/size.py)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dkistner @kon-angelo @gardener-robot-ci-1 @gardener-robot-ci-3 @gardener-robot