-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add infrastructure ConfigValidator for checking floating pool names #329
Conversation
/invite @ialidzhikov @rfranzke @dkistner |
/squash |
🔥 Oops, something went wrong @stoyanr Command test Runs a testrun that is either specified by command line flags or in the default values. The specified path is rendered as testrun and the current repository is injected as a default location. Example: /test [sub-command] [--flags] Usage: --dry-run Print the rendered testrun --set stringArray sets additional helm values --template run go templating on the configured file before execution --testrunPath string path to the testrun file that should be executed
|
/test |
🔥 Oops, something went wrong @stoyanr Command test Runs a testrun that is either specified by command line flags or in the default values. The specified path is rendered as testrun and the current repository is injected as a default location. Example: /test [sub-command] [--flags] Usage: --dry-run Print the rendered testrun --set stringArray sets additional helm values --template run go templating on the configured file before execution --testrunPath string path to the testrun file that should be executed
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
How to categorize this PR?
/area ops-productivity
/area quality
/kind enhancement
/platform gcp
What this PR does / why we need it:
infrastructure.ConfigValidator
for checking floating pool names. See Add infrastructure config validator gardener#4547.infrastructure.ConfigValidator
implementation.Which issue(s) this PR fixes:
Fixes #328
Special notes for your reviewer:
Release note: