Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "run shoot cluster without overlay if not explicitly specified" #498

Merged
merged 1 commit into from
Sep 30, 2022
Merged

Revert "run shoot cluster without overlay if not explicitly specified" #498

merged 1 commit into from
Sep 30, 2022

Conversation

ialidzhikov
Copy link
Member

How to categorize this PR?

/area networking
/kind bug
/platform openstack

What this PR does / why we need it:
This reverts commit 49ac2da.

Which issue(s) this PR fixes:
Fixes the provider-openstack part of gardener/gardener-extension-provider-aws#621, see gardener/gardener-extension-provider-aws#621 (comment)

Release note:

The automatic enablement of no-overlay network configuration for new Shoots is now reverted. For more details about the motivation, see https://github.com/gardener/gardener-extension-provider-aws/issues/621.

@ialidzhikov ialidzhikov requested review from a team as code owners September 28, 2022 14:30
@gardener-robot gardener-robot added the needs/review Needs review label Sep 28, 2022
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Sep 28, 2022
@gardener-robot gardener-robot added area/networking Networking related kind/bug Bug platform/openstack OpenStack platform/infrastructure size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) labels Sep 28, 2022
@kon-angelo kon-angelo added this to the v1.29 milestone Sep 30, 2022
kon-angelo
kon-angelo approved these changes Sep 30, 2022
View reviewed changes
Copy link
Contributor

@kon-angelo kon-angelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Sep 30, 2022
@kon-angelo
Copy link
Contributor

/reviewed ok-to-test

@gardener-robot gardener-robot added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 30, 2022
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 30, 2022
@kon-angelo kon-angelo merged commit f285630 into gardener:master Sep 30, 2022
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Sep 30, 2022
@ialidzhikov ialidzhikov deleted the revert/no-overlay-by-default branch September 30, 2022 10:19
nschad pushed a commit to stackitcloud/gardener-extension-provider-openstack that referenced this pull request Dec 14, 2022
@ialidzhikov
Revert "run shoot cluster without overlay if not explicitly specified" (
da14273 
gardener#498)

This reverts commit 49ac2da.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kon-angelo kon-angelo kon-angelo approved these changes

Assignees
No one assigned
Labels
area/networking Networking related kind/bug Bug needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) platform/openstack OpenStack platform/infrastructure reviewed/lgtm Has approval for merging size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
v1.29
Development

Successfully merging this pull request may close these issues.
5 participants
@ialidzhikov @kon-angelo @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot