Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support app credentials in tests #742

Merged
merged 40 commits into from
May 6, 2024
Merged

Support app credentials in tests #742

merged 40 commits into from
May 6, 2024

Conversation

hebelsan
Copy link
Contributor

@hebelsan hebelsan commented Apr 4, 2024 •
edited
Loading

How to categorize this PR?

/area testing
/kind cleanup
/platform openstack

What this PR does / why we need it:

  • support app credentials in e2e tests
  • add retry in bastion e2e test
  • use internal os client for integration tests
  • add get by id for networks and subnets in network client

Which issue(s) this PR fixes:
Fixes #180

Special notes for your reviewer:

Release note:

Infrastructure tests now support application credentials

hebelsan and others added 16 commits March 26, 2024 11:12
@gardener-robot gardener-robot added the platform/openstack OpenStack platform/infrastructure label Apr 4, 2024
@gardener-robot
Copy link

@hebelsan Labels area/todo, kind/todo do not exist.

@gardener-robot gardener-robot added needs/review Needs review size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) labels Apr 4, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 4, 2024
@gardener-robot gardener-robot added the needs/second-opinion Needs second review by someone else label Apr 4, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Apr 4, 2024
@gardener-robot
Copy link

@hebelsan Labels area/todo, kind/todo do not exist.

2 similar comments
@gardener-robot
Copy link

@hebelsan Labels area/todo, kind/todo do not exist.

@gardener-robot
Copy link

@hebelsan Labels area/todo, kind/todo do not exist.

@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 4, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 4, 2024
@gardener-robot gardener-robot added the kind/api-change API change with impact on API users label Apr 10, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 10, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 10, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 10, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 10, 2024
@hebelsan
Copy link
Contributor Author

/test

@testmachinery
Copy link

testmachinery bot commented Apr 11, 2024 •
edited
Loading

Testrun: e2e-qtmpg
Workflow: e2e-qtmpg-wf
Phase: Failed

+---------------------+---------------------+--------+----------+
|        NAME         |        STEP         | PHASE  | DURATION |
+---------------------+---------------------+--------+----------+
| infrastructure-test | infrastructure-test | Failed | 15m26s   |
| bastion-test        | bastion-test        | Failed | 4m45s    |
+---------------------+---------------------+--------+----------+

@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 11, 2024
@hebelsan
Copy link
Contributor Author

/test

@testmachinery
Copy link

testmachinery bot commented Apr 11, 2024 •
edited
Loading

Testrun: e2e-85qxn
Workflow: e2e-85qxn-wf
Phase: Succeeded

+---------------------+---------------------+-----------+----------+
|        NAME         |        STEP         |   PHASE   | DURATION |
+---------------------+---------------------+-----------+----------+
| bastion-test        | bastion-test        | Succeeded | 3m59s    |
| infrastructure-test | infrastructure-test | Succeeded | 14m24s   |
+---------------------+---------------------+-----------+----------+

@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 11, 2024
@hebelsan hebelsan marked this pull request as ready for review April 11, 2024 10:54
@hebelsan hebelsan requested review from a team as code owners April 11, 2024 10:54
kon-angelo
kon-angelo approved these changes May 6, 2024
View reviewed changes
Copy link
Contributor

@kon-angelo kon-angelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/rebase Needs git rebase needs/review Needs review needs/second-opinion Needs second review by someone else labels May 6, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels May 6, 2024
@kon-angelo kon-angelo merged commit a23bed3 into gardener:master May 6, 2024
16 checks passed
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kon-angelo kon-angelo kon-angelo approved these changes

Assignees
No one assigned
Labels
area/testing Testing related kind/api-change API change with impact on API users kind/cleanup Something that is not needed anymore and can be cleaned up needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) platform/openstack OpenStack platform/infrastructure reviewed/lgtm Has approval for merging size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Infra integration test failing on PR
6 participants
@hebelsan @gardener-robot @kon-angelo @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3