Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GEP-26] CredentialsBinding validation via admission webhook #845

Merged
merged 3 commits into from
Sep 23, 2024
Merged

[GEP-26] CredentialsBinding validation via admission webhook #845

merged 3 commits into from
Sep 23, 2024

Conversation

dimityrmirchev
Copy link
Member

How to categorize this PR?

/area security ipcei
/kind enhancement
/label ipcei/workload-identity
/platform openstack

What this PR does / why we need it:

Which issue(s) this PR fixes:
Part of gardener/gardener#9586

Special notes for your reviewer:
cc @vpnachev

Release note:

The admission webhook now validates `CredentialsBinding`s.

@dimityrmirchev dimityrmirchev requested review from a team as code owners September 4, 2024 09:04
@gardener-robot gardener-robot added needs/review Needs review area/ipcei IPCEI (Important Project of Common European Interest) area/security Security related kind/enhancement Enhancement, improvement, extension platform/openstack OpenStack platform/infrastructure labels Sep 4, 2024
@gardener-robot
Copy link

@dimityrmirchev Label ipcei/workload-identity does not exist.

@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 4, 2024
@gardener-robot gardener-robot added the size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) label Sep 4, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Sep 4, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Sep 4, 2024
@dimityrmirchev dimityrmirchev marked this pull request as draft September 5, 2024 13:19
@dimityrmirchev
Copy link
Member Author

Converting to draft until gardener/gardener-extension-provider-aws#1047 is finalized.

@vpnachev vpnachev mentioned this pull request Sep 11, 2024
Open
51 tasks
@dimityrmirchev dimityrmirchev marked this pull request as ready for review September 20, 2024 10:41
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 20, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 20, 2024
kon-angelo
kon-angelo approved these changes Sep 23, 2024
View reviewed changes
Copy link
Contributor

@kon-angelo kon-angelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Sep 23, 2024
@kon-angelo kon-angelo merged commit d0c58df into gardener:master Sep 23, 2024
11 checks passed
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 23, 2024
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kon-angelo kon-angelo kon-angelo approved these changes

Assignees
No one assigned
Labels
area/ipcei IPCEI (Important Project of Common European Interest) area/security Security related kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) platform/openstack OpenStack platform/infrastructure reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@dimityrmirchev @gardener-robot @kon-angelo @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3