Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix possible nil-ptr-deref #879

Merged
merged 1 commit into from
Oct 17, 2024
Merged

Fix possible nil-ptr-deref #879

merged 1 commit into from
Oct 17, 2024

Conversation

AndreasBurger
Copy link
Member

@AndreasBurger AndreasBurger commented Oct 17, 2024 •
edited
Loading

How to categorize this PR?

/area robustness
/kind bug
/platform openstack

What this PR does / why we need it:
Fixes a possible nil-ptr deref and replaces it with an error

Which issue(s) this PR fixes:
Fixes #878

Special notes for your reviewer:

Release note:

Fix possible nil-pointer deref when looking for networks. during reconciliation

@AndreasBurger AndreasBurger requested review from a team as code owners October 17, 2024 07:44
@gardener-robot gardener-robot added the needs/review Needs review label Oct 17, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Oct 17, 2024
@gardener-robot gardener-robot added area/robustness Robustness, reliability, resilience related kind/bug Bug platform/openstack OpenStack platform/infrastructure size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Oct 17, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Oct 17, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Oct 17, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Oct 17, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Oct 17, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Oct 17, 2024
kon-angelo
kon-angelo approved these changes Oct 17, 2024
View reviewed changes
Copy link
Contributor

@kon-angelo kon-angelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kon-angelo kon-angelo merged commit b991f4a into master Oct 17, 2024
10 checks passed
@kon-angelo kon-angelo deleted the nil-fix branch October 17, 2024 09:02
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kon-angelo kon-angelo kon-angelo approved these changes

Assignees
No one assigned
Labels
area/robustness Robustness, reliability, resilience related kind/bug Bug needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review platform/openstack OpenStack platform/infrastructure size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

gardener-extension-provider-openstack PODs are in CrashLoopBackOff
6 participants
@AndreasBurger @kon-angelo @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot