-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add e2e for upstream registries that require credentials #184
Add e2e for upstream registries that require credentials #184
Conversation
Skipping CI for Draft Pull Request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice PR! 🚀
Cosmetic suggestions inline.
test/e2e/cache/create_enable_add_with_private_registry_delete.go
Outdated
Show resolved
Hide resolved
test/e2e/cache/create_enable_add_with_private_registry_delete.go
Outdated
Show resolved
Hide resolved
test/e2e/cache/create_enable_add_with_private_registry_delete.go
Outdated
Show resolved
Hide resolved
test/e2e/cache/create_enable_add_with_private_registry_delete.go
Outdated
Show resolved
Hide resolved
test/e2e/cache/create_enable_add_with_private_registry_delete.go
Outdated
Show resolved
Hide resolved
test/e2e/cache/create_enable_add_with_private_registry_delete.go
Outdated
Show resolved
Hide resolved
test/e2e/cache/create_enable_add_with_private_registry_delete.go
Outdated
Show resolved
Hide resolved
test/e2e/cache/create_enable_add_with_private_registry_delete.go
Outdated
Show resolved
Hide resolved
test/e2e/cache/create_enable_add_with_private_registry_delete.go
Outdated
Show resolved
Hide resolved
test/e2e/cache/create_enable_add_with_private_registry_delete.go
Outdated
Show resolved
Hide resolved
369a9a3
to
a9d040a
Compare
The Gardener project currently lacks enough active contributors to adequately respond to all PRs.
You can:
/lifecycle stale |
/remove-lifecycle stale |
a9d040a
to
1e0eb6c
Compare
1e0eb6c
to
e10a9e7
Compare
The Gardener project currently lacks enough active contributors to adequately respond to all PRs.
You can:
/lifecycle stale |
/remove-lifecycle stale |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Final comments from my side, rest looks good
7b5f492
to
4a08b94
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks much better now. Final suggestion, then lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: be1aca420dc3462c1202985321492f43669390ce
|
@dimitar-kostadinov can you rebase and force push so that the |
…64 platforms, use `ctr images pull --all-platforms` to fix test failure due to wrong image arch
98b6cfc
to
8381e32
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: f1025bdb0530115c1324e665cb155f02d18be352
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ialidzhikov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
How to categorize this PR?
/area testing
/kind test
What this PR does / why we need it:
Add e2e test for upstream registry that requires credentials.
Which issue(s) this PR fixes:
Part of #3
Special notes for your reviewer:
The upstream registry is deployed in the Shoot as
test-registry
pod and service underkube-system
namespace.The PR will remain a draft until
distribution/distribution#4263 is merged and registry:3.0.0 is released.issue with ctr v1.7.15 - Ref: containerd/containerd#10014 is fixed in kindest/node version > v1.30.2Release note: