Add e2e for upstream registries that require credentials #184

dimitar-kostadinov · 2024-04-18T14:59:03Z

How to categorize this PR?

/area testing
/kind test

What this PR does / why we need it:
Add e2e test for upstream registry that requires credentials.

Which issue(s) this PR fixes:
Part of #3

Special notes for your reviewer:
The upstream registry is deployed in the Shoot as test-registry pod and service under kube-system namespace.
The PR will remain a draft until ~~distribution/distribution#4263 is merged and registry:3.0.0 is released.~~
~~issue with ctr v1.7.15 - Ref: containerd/containerd#10014 is fixed in kindest/node version > v1.30.2~~

Release note:

A new e2e test that covers upstream registries with credentials is now added.

gardener-prow · 2024-04-18T14:59:07Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

ialidzhikov

Nice PR! 🚀

Cosmetic suggestions inline.

test/e2e/cache/create_enable_add_with_private_registry_delete.go

gardener-ci-robot · 2024-05-11T13:55:11Z

The Gardener project currently lacks enough active contributors to adequately respond to all PRs.
This bot triages PRs according to the following rules:

After 15d of inactivity, lifecycle/stale is applied
After 15d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 7d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle stale
Mark this PR as rotten with /lifecycle rotten
Close this PR with /close

/lifecycle stale

ialidzhikov · 2024-05-11T18:52:20Z

/remove-lifecycle stale

gardener-ci-robot · 2024-06-20T10:30:58Z

The Gardener project currently lacks enough active contributors to adequately respond to all PRs.
This bot triages PRs according to the following rules:

After 15d of inactivity, lifecycle/stale is applied
After 15d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 7d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle stale
Mark this PR as rotten with /lifecycle rotten
Close this PR with /close

/lifecycle stale

ialidzhikov · 2024-06-20T10:51:10Z

/remove-lifecycle stale

ialidzhikov

Final comments from my side, rest looks good

test/e2e/cache/create_enable_for_private_registry_delete.go

ialidzhikov

Looks much better now. Final suggestion, then lgtm

test/e2e/cache/create_enable_for_private_registry_delete.go

ialidzhikov

/lgtm

gardener-prow · 2024-09-17T14:07:30Z

LGTM label has been added.

Git tree hash: be1aca420dc3462c1202985321492f43669390ce

ialidzhikov · 2024-09-18T06:10:35Z

@dimitar-kostadinov can you rebase and force push so that the concourse-ci/helmcharts check gets removed on its own?

…64 platforms, use `ctr images pull --all-platforms` to fix test failure due to wrong image arch

ialidzhikov

/lgtm

gardener-prow · 2024-09-18T09:02:57Z

LGTM label has been added.

Git tree hash: f1025bdb0530115c1324e665cb155f02d18be352

gardener-prow · 2024-09-18T09:02:59Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ialidzhikov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [ialidzhikov]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

gardener-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 18, 2024

gardener-prow bot added area/testing Testing related kind/test Test cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. labels Apr 18, 2024

gardener-prow bot requested a review from ialidzhikov April 18, 2024 14:59

gardener-prow bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 18, 2024

dimitar-kostadinov mentioned this pull request Apr 18, 2024

Getting gardener-extension-registry-cache production ready #3

Closed

96 tasks

gardener-prow bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 19, 2024

ialidzhikov reviewed Apr 22, 2024

View reviewed changes

dimitar-kostadinov force-pushed the enh/e2e-private-registry-test branch from 369a9a3 to a9d040a Compare April 26, 2024 13:53

gardener-prow bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 26, 2024

gardener-prow bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 11, 2024

gardener-prow bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 11, 2024

dimitar-kostadinov added area/ipcei IPCEI (Important Project of Common European Interest) ipcei/registry-cache-extension Registry Cache Extension labels May 21, 2024

gardener-prow bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 27, 2024

dimitar-kostadinov force-pushed the enh/e2e-private-registry-test branch from a9d040a to 1e0eb6c Compare May 28, 2024 09:23

gardener-prow bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels May 28, 2024

dimitar-kostadinov force-pushed the enh/e2e-private-registry-test branch from 1e0eb6c to e10a9e7 Compare May 29, 2024 12:36

gardener-prow bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 29, 2024

ialidzhikov mentioned this pull request Jun 3, 2024

Adopt the distribution@v3.0.0 release (when it is available) #202

Closed

gardener-prow bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 5, 2024

gardener-prow bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 20, 2024

gardener-prow bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 20, 2024

gardener-prow bot assigned ialidzhikov Sep 2, 2024

gardener-prow bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 9, 2024

ialidzhikov reviewed Sep 9, 2024

View reviewed changes

dimitar-kostadinov force-pushed the enh/e2e-private-registry-test branch from 7b5f492 to 4a08b94 Compare September 17, 2024 10:05

gardener-prow bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 17, 2024

ialidzhikov reviewed Sep 17, 2024

View reviewed changes

test/e2e/cache/create_enable_for_private_registry_delete.go Outdated Show resolved Hide resolved

gardener-robot-ci-1 added the reviewed/ok-to-test label Sep 17, 2024

ialidzhikov approved these changes Sep 17, 2024

View reviewed changes

gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Sep 17, 2024

gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 17, 2024

gardener-robot-ci-2 added needs/ok-to-test reviewed/ok-to-test and removed reviewed/ok-to-test labels Sep 17, 2024

dimitar-kostadinov added 6 commits September 18, 2024 11:48

Add e2e for upstream registries that require credentials

5d59165

Address PR review feedback

0a25713

Replace the use of image digest with image tag

aae4299

Since public.ecr.aws/nginx/nginx:1.24.0 supports only amd64 and arm…

7d700fb

…64 platforms, use `ctr images pull --all-platforms` to fix test failure due to wrong image arch

Address PR review feedback

4f261de

Address PR review feedback

8381e32

dimitar-kostadinov force-pushed the enh/e2e-private-registry-test branch from 98b6cfc to 8381e32 Compare September 18, 2024 08:48

gardener-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 18, 2024

gardener-prow bot requested a review from ialidzhikov September 18, 2024 08:48

ialidzhikov approved these changes Sep 18, 2024

View reviewed changes

gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Sep 18, 2024

gardener-prow bot merged commit a67a1d9 into gardener:main Sep 18, 2024
6 checks passed

dimitar-kostadinov deleted the enh/e2e-private-registry-test branch September 18, 2024 13:02

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add e2e for upstream registries that require credentials #184

Add e2e for upstream registries that require credentials #184

dimitar-kostadinov commented Apr 18, 2024 •

edited by ialidzhikov

Loading

gardener-prow bot commented Apr 18, 2024

ialidzhikov left a comment

gardener-ci-robot commented May 11, 2024

ialidzhikov commented May 11, 2024

gardener-ci-robot commented Jun 20, 2024

ialidzhikov commented Jun 20, 2024

ialidzhikov left a comment

ialidzhikov left a comment

ialidzhikov left a comment

gardener-prow bot commented Sep 17, 2024

ialidzhikov commented Sep 18, 2024 •

edited

Loading

ialidzhikov left a comment

gardener-prow bot commented Sep 18, 2024

gardener-prow bot commented Sep 18, 2024

Add e2e for upstream registries that require credentials #184

Add e2e for upstream registries that require credentials #184

Conversation

dimitar-kostadinov commented Apr 18, 2024 • edited by ialidzhikov Loading

gardener-prow bot commented Apr 18, 2024

ialidzhikov left a comment

Choose a reason for hiding this comment

gardener-ci-robot commented May 11, 2024

ialidzhikov commented May 11, 2024

gardener-ci-robot commented Jun 20, 2024

ialidzhikov commented Jun 20, 2024

ialidzhikov left a comment

Choose a reason for hiding this comment

ialidzhikov left a comment

Choose a reason for hiding this comment

ialidzhikov left a comment

Choose a reason for hiding this comment

gardener-prow bot commented Sep 17, 2024

ialidzhikov commented Sep 18, 2024 • edited Loading

ialidzhikov left a comment

Choose a reason for hiding this comment

gardener-prow bot commented Sep 18, 2024

gardener-prow bot commented Sep 18, 2024

dimitar-kostadinov commented Apr 18, 2024 •

edited by ialidzhikov

Loading

ialidzhikov commented Sep 18, 2024 •

edited

Loading