-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configure TLS communication between registry cache and containerd #245
base: main
Are you sure you want to change the base?
Configure TLS communication between registry cache and containerd #245
Conversation
Skipping CI for Draft Pull Request. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/assign |
The Gardener project currently lacks enough active contributors to adequately respond to all PRs.
You can:
/lifecycle stale |
/remove-lifecycle stale |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, @dimitar-kostadinov!
Sorry for the long delay! I am posting some very minor preliminary comments for now! I will do a more detailed review in CW42.
Can you meanwhile also rebase?
charts/gardener-extension-registry-cache/templates/clusterrole.yaml
Outdated
Show resolved
Hide resolved
@@ -22,6 +22,9 @@ http: | |||
enabled: true | |||
path: /metrics | |||
draintimeout: 25s | |||
tls: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could add e2e tests for CA rotation to make sure that we don't regress the scenario in future.
724c96c
to
594e1b5
Compare
594e1b5
to
5432210
Compare
5432210
to
f5d18df
Compare
How to categorize this PR?
/area security
/kind enhancement
What this PR does / why we need it:
Configure TLS communication between registry cache and containerd.
Which issue(s) this PR fixes:
Fixes #203
Special notes for your reviewer:
Release note: