Replace use of public.ecr.aws/nginx/nginx with ghcr.io/jitesoft/alpine image
#254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-prow
bot
added
area/testing
gardener-prow
bot
added
cla: yes
|
/assign |
dimitar-kostadinov
force-pushed
the
remove-public.ecr.aws
branch
from
2835213
to
5e69c14
Compare
gardener-prow
bot
added
size/L
dimitar-kostadinov
force-pushed
the
remove-public.ecr.aws
branch
from
5e69c14
to
1a3b22b
Compare
ialidzhikov
reviewed
Sep 9, 2024
test/common/common.go
Outdated
Comment on lines
43
to
44
| // GitlabRegistryJitesoftAlpine31710Image is the registry.gitlab.com/jitesoft/dockerfiles/alpine:3.17.10 image. | ||
| GitlabRegistryJitesoftAlpine31710Image = "registry.gitlab.com/jitesoft/dockerfiles/alpine:3.17.10" |
There was a problem hiding this comment.
Nit: You could move it above to the group of the alpine images.
Comment on lines
39
to
42
| // ArtifactRegistryNginx1176Image is the europe-docker.pkg.dev/gardener-project/releases/3rd/nginx:1.17.6 image (copy of docker.io/library/nginx:1.17.6). | ||
| ArtifactRegistryNginx1176Image = "europe-docker.pkg.dev/gardener-project/releases/3rd/nginx:1.17.6" | ||
| // RegistryK8sNginx1154Image is the registry.k8s.io/e2e-test-images/nginx:1.15-4 image. | ||
| RegistryK8sNginx1154Image = "registry.k8s.io/e2e-test-images/nginx:1.15-4" |
There was a problem hiding this comment.
I see that we still have nginx image. Do we plan to switch them as well to alpine in a follow-up PR?
IIRC this is a band-aid PR to migration from ECR. But IMO in a follow-up PR we can also change the other nginx images to alpine. WDYT?
There was a problem hiding this comment.
I think we can keep it flexible and use different container images in the tests.
ialidzhikov
changed the title
public.ecr.aws/nginx/nginx with quay.io/jitesoft/apine imagepublic.ecr.aws/nginx/nginx with quay.io/jitesoft/alpine image
|
LGTM label has been added. Git tree hash: 1028183232c885ec9735ef4c0d50fdce33ef4d1d
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ialidzhikov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
gardener-prow
bot
added
the
approved
dimitar-kostadinov
changed the title
public.ecr.aws/nginx/nginx with quay.io/jitesoft/alpine imagepublic.ecr.aws/nginx/nginx with ghcr.io/jitesoft/alpine image
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area testing
/kind flake
What this PR does / why we need it:
There is an issue when
distribution/distributionis used as a pull-through cache to Amazon Public ECR Gallery. Sometimes image manifests are successfully cached, but download of image layers blobs fails withInternal Server Error - 500.With this PR
public.ecr.aws/nginx/nginximage is replaced withghcr.io/jitesoft/alpine. TheVerifyRegistryCachefunc is extended to support various images.Which issue(s) this PR fixes:
N/A
Special notes for your reviewer:
N/A
Release note: