-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace use of public.ecr.aws/nginx/nginx
with ghcr.io/jitesoft/alpine
image
#254
Replace use of public.ecr.aws/nginx/nginx
with ghcr.io/jitesoft/alpine
image
#254
Conversation
/assign |
2835213
to
5e69c14
Compare
5e69c14
to
1a3b22b
Compare
test/common/common.go
Outdated
// GitlabRegistryJitesoftAlpine31710Image is the registry.gitlab.com/jitesoft/dockerfiles/alpine:3.17.10 image. | ||
GitlabRegistryJitesoftAlpine31710Image = "registry.gitlab.com/jitesoft/dockerfiles/alpine:3.17.10" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: You could move it above to the group of the alpine images.
// ArtifactRegistryNginx1176Image is the europe-docker.pkg.dev/gardener-project/releases/3rd/nginx:1.17.6 image (copy of docker.io/library/nginx:1.17.6). | ||
ArtifactRegistryNginx1176Image = "europe-docker.pkg.dev/gardener-project/releases/3rd/nginx:1.17.6" | ||
// RegistryK8sNginx1154Image is the registry.k8s.io/e2e-test-images/nginx:1.15-4 image. | ||
RegistryK8sNginx1154Image = "registry.k8s.io/e2e-test-images/nginx:1.15-4" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see that we still have nginx image. Do we plan to switch them as well to alpine in a follow-up PR?
IIRC this is a band-aid PR to migration from ECR. But IMO in a follow-up PR we can also change the other nginx images to alpine. WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can keep it flexible and use different container images in the tests.
public.ecr.aws/nginx/nginx
with quay.io/jitesoft/apine
imagepublic.ecr.aws/nginx/nginx
with quay.io/jitesoft/alpine
image
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: 1028183232c885ec9735ef4c0d50fdce33ef4d1d
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ialidzhikov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
public.ecr.aws/nginx/nginx
with quay.io/jitesoft/alpine
imagepublic.ecr.aws/nginx/nginx
with ghcr.io/jitesoft/alpine
image
How to categorize this PR?
/area testing
/kind flake
What this PR does / why we need it:
There is an issue when
distribution/distribution
is used as a pull-through cache to Amazon Public ECR Gallery. Sometimes image manifests are successfully cached, but download of image layers blobs fails withInternal Server Error - 500
.With this PR
public.ecr.aws/nginx/nginx
image is replaced withghcr.io/jitesoft/alpine
. TheVerifyRegistryCache
func is extended to support various images.Which issue(s) this PR fixes:
N/A
Special notes for your reviewer:
N/A
Release note: