Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve image pull check #255

Merged

Conversation

dimitar-kostadinov
Copy link
Contributor

@dimitar-kostadinov dimitar-kostadinov commented Sep 9, 2024

How to categorize this PR?

/area testing
/kind enhancement

What this PR does / why we need it:
Improves image pull check with following:

  • extract the image manifest for Node architecture from the index file
  • extract all image layers from the manifest
  • ensure that all image layers data files exist in the registry storage

Which issue(s) this PR fixes:
N/A

Special notes for your reviewer:
N/A

Release note:

The verification in the e2e test is enhanced to check that all image layers of an image are present in the registry cache storage.

@gardener-prow gardener-prow bot added area/testing Testing related kind/enhancement Enhancement, improvement, extension labels Sep 9, 2024
@gardener-prow gardener-prow bot added cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 9, 2024
Copy link
Member

@ialidzhikov ialidzhikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

test/common/common.go Outdated Show resolved Hide resolved
test/common/common.go Outdated Show resolved Hide resolved
test/common/common.go Outdated Show resolved Hide resolved
test/common/common.go Outdated Show resolved Hide resolved
test/common/common.go Outdated Show resolved Hide resolved
test/common/common.go Outdated Show resolved Hide resolved
Copy link
Member

@ialidzhikov ialidzhikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you check why an e2e test failed again?

  [FAILED] Context was cancelled (cause: context deadline exceeded) after 120.001s.
  Expected to successfully find the registry.k8s.io/e2e-test-images/nginx:1.15-4 image in the registry's volume
  Expected success, but got an error:
      <*fmt.wrapError | 0xc0006be7e0>: 
      failed to get the registry.k8s.io/e2e-test-images/nginx:1.15-4 image index digest: context deadline exceeded
      {
          msg: "failed to get the registry.k8s.io/e2e-test-images/nginx:1.15-4 image index digest: context deadline exceeded",
          err: <*errors.joinError | 0xc00033ef48>{
              errs: [
                  <context.deadlineExceededError>{},
              ],
          },
      }
  In [It] at: /home/prow/go/src/github.com/gardener/gardener-extension-registry-cache/test/e2e/cache/create_enabled_delete_shoot_system_components.go:47 @ 09/17/24 14:31:14.818

test/common/common.go Outdated Show resolved Hide resolved
test/common/common.go Outdated Show resolved Hide resolved
test/common/common.go Outdated Show resolved Hide resolved
@ialidzhikov
Copy link
Member

@dimitar-kostadinov can you rebase and force push so that the concourse-ci/helmcharts check gets removed on its own?

Copy link
Member

@ialidzhikov ialidzhikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Sep 18, 2024
Copy link
Contributor

gardener-prow bot commented Sep 18, 2024

LGTM label has been added.

Git tree hash: 5023b69e82db00530270b563b05712027216ca7f

Copy link
Contributor

gardener-prow bot commented Sep 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ialidzhikov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 18, 2024
@dimitar-kostadinov
Copy link
Contributor Author

/test pull-gardener-extension-registry-cache-e2e-kind

@dimitar-kostadinov
Copy link
Contributor Author

/hold

@gardener-prow gardener-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 18, 2024
@gardener-ci-robot
Copy link

The Gardener project currently lacks enough active contributors to adequately respond to all PRs.
This bot triages PRs according to the following rules:

  • After 15d of inactivity, lifecycle/stale is applied
  • After 15d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 7d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Mark this PR as rotten with /lifecycle rotten
  • Close this PR with /close

/lifecycle stale

@gardener-prow gardener-prow bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 4, 2024
@ialidzhikov
Copy link
Member

/remove-lifecycle stale

@gardener-prow gardener-prow bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 4, 2024
@dimitar-kostadinov
Copy link
Contributor Author

/test pull-gardener-extension-registry-cache-e2e-kind

@dimitar-kostadinov
Copy link
Contributor Author

/unhold

@gardener-prow gardener-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 8, 2024
@gardener-prow gardener-prow bot merged commit 24658b3 into gardener:main Oct 8, 2024
6 checks passed
@dimitar-kostadinov dimitar-kostadinov deleted the enh/image-pull-checks branch October 8, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/testing Testing related cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/enhancement Enhancement, improvement, extension lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants