-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve image pull check #255
Improve image pull check #255
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you check why an e2e test failed again?
[FAILED] Context was cancelled (cause: context deadline exceeded) after 120.001s.
Expected to successfully find the registry.k8s.io/e2e-test-images/nginx:1.15-4 image in the registry's volume
Expected success, but got an error:
<*fmt.wrapError | 0xc0006be7e0>:
failed to get the registry.k8s.io/e2e-test-images/nginx:1.15-4 image index digest: context deadline exceeded
{
msg: "failed to get the registry.k8s.io/e2e-test-images/nginx:1.15-4 image index digest: context deadline exceeded",
err: <*errors.joinError | 0xc00033ef48>{
errs: [
<context.deadlineExceededError>{},
],
},
}
In [It] at: /home/prow/go/src/github.com/gardener/gardener-extension-registry-cache/test/e2e/cache/create_enabled_delete_shoot_system_components.go:47 @ 09/17/24 14:31:14.818
@dimitar-kostadinov can you rebase and force push so that the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: 5023b69e82db00530270b563b05712027216ca7f
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ialidzhikov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test pull-gardener-extension-registry-cache-e2e-kind |
/hold |
The Gardener project currently lacks enough active contributors to adequately respond to all PRs.
You can:
/lifecycle stale |
/remove-lifecycle stale |
/test pull-gardener-extension-registry-cache-e2e-kind |
/unhold |
How to categorize this PR?
/area testing
/kind enhancement
What this PR does / why we need it:
Improves image pull check with following:
Which issue(s) this PR fixes:
N/A
Special notes for your reviewer:
N/A
Release note: