Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle RuntimeClass node.k8s.io/v1 #58

Merged
merged 1 commit into from
Sep 2, 2022
Merged

Handle RuntimeClass node.k8s.io/v1 #58

merged 1 commit into from
Sep 2, 2022

Conversation

shafeeqes
Copy link
Contributor

What this PR does / why we need it:
RuntimeClass in the node.k8s.io/v1beta1 API version will no longer be served in v1.25. Ref

Which issue(s) this PR fixes:
Part of gardener/gardener#6567

Special notes for your reviewer:

Release note:

NONE

@shafeeqes shafeeqes requested a review from a team as a code owner September 1, 2022 07:56
@gardener-robot gardener-robot added needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Sep 1, 2022
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Sep 1, 2022
@shafeeqes shafeeqes marked this pull request as draft September 2, 2022 05:56
@shafeeqes shafeeqes marked this pull request as ready for review September 2, 2022 09:03
@shafeeqes
Copy link
Contributor Author

/cc @acumino

@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 2, 2022
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 2, 2022
acumino
acumino approved these changes Sep 2, 2022
View reviewed changes
Copy link
Member

@acumino acumino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Sep 2, 2022
@acumino
Copy link
Member

acumino commented Sep 2, 2022

/invite @ialidzhikov

@gardener-robot gardener-robot added needs/review Needs review and removed reviewed/lgtm Has approval for merging labels Sep 2, 2022
ialidzhikov
ialidzhikov approved these changes Sep 2, 2022
View reviewed changes
Copy link
Member

@ialidzhikov ialidzhikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Sep 2, 2022
@ialidzhikov ialidzhikov added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 2, 2022
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 2, 2022
@ialidzhikov ialidzhikov merged commit 0ecf3a2 into gardener:master Sep 2, 2022
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Sep 2, 2022
@shafeeqes shafeeqes deleted the enh/RC branch September 2, 2022 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ialidzhikov ialidzhikov ialidzhikov approved these changes

@acumino acumino acumino approved these changes

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@shafeeqes @acumino @ialidzhikov @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot