-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve message on stucking dnsentry deletion #155
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one Nit. Looks good otherwise, thanks for the improvement 👍
pkg/controller/lifecycle/actuator.go
Outdated
status = append(status, "no suitable provider") | ||
continue | ||
} | ||
parts := strings.Split(k, "/") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit
parts := strings.Split(k, "/") | |
parts := strings.Split(k, types.Separator) |
Package: k8s.io/apimachinery/pkg/types
You could also use kutils.ParseObjectName
(ref).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using kutils.ParseObjectName
1d163c7
to
4d3a977
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thank you!
/lgtm
status = append(status, fmt.Sprintf("error on retrieving status of provider %s: %s", k, err)) | ||
continue | ||
} | ||
status = append(status, fmt.Sprintf("provider %s has status: %s", name, pointer.StringDeref(provider.Status.Message, "unknwon"))) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
boah, what is this.
Don'y want to use string variable, to get an address for a string
How to categorize this PR?
/area control-plane
/kind enhancement
What this PR does / why we need it:
Improve error message for DNS entry failed deletion
Which issue(s) this PR fixes:
Fixes #154
Release note: