Improve message on stucking dnsentry deletion #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot
added
area/control-plane
gardener-robot-ci-1
added
the
reviewed/ok-to-test
gardener-robot-ci-2
added
needs/ok-to-test
mandelsoft
previously approved these changes
Aug 29, 2022
timuthy
reviewed
Aug 29, 2022
pkg/controller/lifecycle/actuator.go
Outdated
| status = append(status, "no suitable provider") | ||
| continue | ||
| } | ||
| parts := strings.Split(k, "/") |
There was a problem hiding this comment.
Nit
Suggested change
| parts := strings.Split(k, "/") | |
| parts := strings.Split(k, types.Separator) |
Package: k8s.io/apimachinery/pkg/types
You could also use kutils.ParseObjectName (ref).
There was a problem hiding this comment.
Using kutils.ParseObjectName
MartinWeindel
force-pushed
the
improve-msg-on-stucking-dnse-deletion
branch
from
1d163c7
to
4d3a977
Compare
gardener-robot-ci-3
added
reviewed/ok-to-test
gardener-robot
added
reviewed/lgtm
gardener-robot
added
the
status/closed
mandelsoft
reviewed
Aug 31, 2022
| status = append(status, fmt.Sprintf("error on retrieving status of provider %s: %s", k, err)) | ||
| continue | ||
| } | ||
| status = append(status, fmt.Sprintf("provider %s has status: %s", name, pointer.StringDeref(provider.Status.Message, "unknwon"))) |
There was a problem hiding this comment.
boah, what is this.
Don'y want to use string variable, to get an address for a string
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area control-plane
/kind enhancement
What this PR does / why we need it:
Improve error message for DNS entry failed deletion
Which issue(s) this PR fixes:
Fixes #154
Release note: