Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump github.com/ahmetb/gen-crd-api-reference-docs to master #388

Merged
merged 1 commit into from
Oct 18, 2024
Merged

Bump github.com/ahmetb/gen-crd-api-reference-docs to master #388

merged 1 commit into from
Oct 18, 2024

Conversation

MartinWeindel
Copy link
Member

@MartinWeindel MartinWeindel commented Oct 18, 2024 •
edited
Loading

How to categorize this PR?

/area delivery
/kind bug

What this PR does / why we need it:
This is a fix for the CI/CD pipeline only.
The make generate target generated different reference strings for DNSEntry in the file hack/api-reference/api.md, depending if it ran on MacOS or Linux. Additionally during the release, it behaved differently on Alpine and Linux which caused the verify step to failed for the first PR after a release.

After updating the github.com/ahmetb/gen-crd-api-reference-docs dependency to a current master commit, the behaviour is now the same on all operating systems.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

NONE

@MartinWeindel MartinWeindel requested review from a team as code owners October 18, 2024 13:33
@gardener-robot gardener-robot added needs/review Needs review area/delivery Delivery related kind/bug Bug size/s Size of pull request is small (see gardener-robot robot/bots/size.py) labels Oct 18, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Oct 18, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Oct 18, 2024
ScheererJ
ScheererJ approved these changes Oct 18, 2024
View reviewed changes
Copy link
Member

@ScheererJ ScheererJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Oct 18, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Oct 18, 2024
@MartinWeindel MartinWeindel merged commit 60c2979 into master Oct 18, 2024
7 checks passed
@MartinWeindel MartinWeindel deleted the fix/generate-api-docu-dnsentry branch October 18, 2024 14:34
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ScheererJ ScheererJ ScheererJ approved these changes

Assignees
No one assigned
Labels
area/delivery Delivery related kind/bug Bug needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/s Size of pull request is small (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@MartinWeindel @ScheererJ @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot