Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use snake case for label name failure_tolerance #81

Merged
merged 1 commit into from
Nov 18, 2022
Merged

Use snake case for label name failure_tolerance #81

merged 1 commit into from
Nov 18, 2022

Conversation

rickardsjp
Copy link
Contributor

What this PR does / why we need it:

Fix label case.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

/cc @istvanballok

Release note:

Use snake case for label name failure_tolerance.

@rickardsjp @istvanballok
Use snake case for label name failure_tolerance
57ebba3 
Co-authored-by: Istvan Zoltan Ballok <istvan.zoltan.ballok@sap.com>
Co-authored-by: Jeremy Rickards <jeremy.rickards@sap.com>
@rickardsjp rickardsjp requested a review from a team as a code owner November 18, 2022 16:06
@gardener-robot gardener-robot added needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Nov 18, 2022
istvanballok
istvanballok approved these changes Nov 18, 2022
View reviewed changes
Copy link
Member

@istvanballok istvanballok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Nov 18, 2022
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 18, 2022
@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 18, 2022
@rickardsjp rickardsjp merged commit 5ac26b3 into master Nov 18, 2022
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@istvanballok istvanballok istvanballok approved these changes

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rickardsjp @istvanballok @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot